refine icon indicating copy to clipboard operation
refine copied to clipboard

feat(supabase): filter array column by array (`ina` and `nina` operators)

Open issa012 opened this issue 1 year ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

  • [x] Related issue(s) linked
  • [x] Tests for the changes have been added
  • [x] Docs have been added / updated
  • [x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

No ina and nina

What is the new behavior?

Now it is possible to filter using ina and nina CRUD operators in supabase data provider. It allows for filtering array columns by matching all values inside array. fixes #5902

Notes for reviewers

issa012 avatar May 06 '24 13:05 issa012

🦋 Changeset detected

Latest commit: 84bf034c7f6df12cfd0837160125cac9f340a19d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/core Minor
@refinedev/supabase Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 06 '24 13:05 changeset-bot[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bdd99ee2dbe0de1287918aec50b934a694495578. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 60 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 06 '24 13:05 nx-cloud[bot]

Deploy Preview for refine-video-club ready!

Name Link
Latest commit 095e45f53c5b24f116a8a688cc1af48c8c3d75e4
Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/663c6d300e5394000829c11a
Deploy Preview https://deploy-preview-5922--refine-video-club.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 09 '24 06:05 netlify[bot]

Hello, @issa012. Thanks for the PR 🚀

As you can see, the CI is failing but this is not related to the changes you made. First, I will solve this problem in another PR and then we will review your PR.

alicanerdurmaz avatar May 09 '24 08:05 alicanerdurmaz

Failing CI will be resolved after #5937 is merged.

aliemir avatar May 10 '24 06:05 aliemir

@issa012 Hello again, will you be able to find time to continue with the PR?

alicanerdurmaz avatar May 23 '24 06:05 alicanerdurmaz

@alicanerdurmaz Hello. Yes I will complete it today

issa012 avatar May 23 '24 06:05 issa012

After pnpm install every package was installed and built, is this normal behavior now?

issa012 avatar May 23 '24 16:05 issa012

Also, there are other filters in supabase, that seem to be missing. If you open an issue with descriptions, I could implement them too.

issa012 avatar May 23 '24 16:05 issa012

Also, there are other filters in supabase, that seem to be missing. If you open an issue with descriptions, I could implement them too.

Thanks, I will look into that! But, If you want, you can open an issue too.

alicanerdurmaz avatar May 24 '24 07:05 alicanerdurmaz

After pnpm install every package was installed and built, is this normal behavior now?

Hey @issa012, this is the expected default behavior with our pnpm monorepo setup. Check out our Contributing Guide you can ignore these builds by passing --ignore-scripts 🚀

aliemir avatar May 24 '24 11:05 aliemir