refine icon indicating copy to clipboard operation
refine copied to clipboard

[BUG] Register AuthPage using wrong i18n key

Open BlackBearFTW opened this issue 1 year ago • 4 comments

Describe the bug

When using the register authpage in combination with i18n, the default auth page is using the wrong key for the "Already have an account" text. It uses pages.login.buttons.haveAccount even tho in the i18n translation file offered by the refine documentation has that key in the pages.register.buttons.haveAccount. This should be changed so it matches pages.login.buttons.noAccount

Steps To Reproduce

  1. Create a refine project (for example vite)
  2. Setup i18n using the refine documentation
  3. Switch languages to a non-english language
  4. See the register page

Expected behavior

It should use the correct key and translate the value

Packages

@refinedev/core @refinedev/antd

Additional Context

No response

BlackBearFTW avatar Apr 03 '24 09:04 BlackBearFTW

Hey @BlackBearFTW thanks for the issue. We are open to contributions for this one.

BatuhanW avatar Apr 04 '24 06:04 BatuhanW

Hey @BatuhanW since the PR linking to this issue is closed. Can i take this up ?. will keep the PR template and provide the necessary info this time.

Ac-Srikanth avatar Apr 18 '24 15:04 Ac-Srikanth

I do not know how to make this changelist without cloning the entire repository to local, so if someone else wants to pick this up go ahead.

BlackBearFTW avatar May 04 '24 21:05 BlackBearFTW

I want to work on this issue. Can you assign this to me?

keremilhan avatar May 06 '24 13:05 keremilhan