refine icon indicating copy to clipboard operation
refine copied to clipboard

feat(mui): add circular progress to <Show>

Open issa012 opened this issue 1 year ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

  • [x] Related issue(s) linked
  • [ ] Tests for the changes have been added
  • [ ] Docs have been added / updated
  • [x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

<Show isLoading={true}> in MUI doesn't show loading spinner

What is the new behavior?

Added loading spinner. fixes #5668

Notes for reviewers

Hello. This is my first PR ever. I have added the <Backdrop> along with <CircularProgress> to render a loading spinner. Should I add the possibility to pass props to these components? Also, what color should they be?

issa012 avatar Mar 01 '24 07:03 issa012

⚠️ No Changeset found

Latest commit: b4ed3be74f13837ebeb1faa3b616c4c1e4744120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 01 '24 07:03 changeset-bot[bot]

Hello @aliemir . What tests should I add for this change? Similar Antd component does not have any tests regarding the loading state. Should I update the documentation?

issa012 avatar Mar 26 '24 05:03 issa012