refine icon indicating copy to clipboard operation
refine copied to clipboard

Fix: Use Material UI notifications provider in documentation code sample

Open Mohamed-khattab opened this issue 1 year ago • 2 comments

The documentation provided an incorrect code sample that utilized the notifications provider from the Ant Design UI package instead of the intended Material UI notifications provider. This commit updates the code sample to import and use the Material UI notifications provider from @refinedev/mui as recommended in the documentation.

Changes:

  • Updated import statement to import the notification provider from @refinedev/mui.
  • Updated the code sample to use the Material UI notifications provider in the <Refine /> component.

What is the current behavior?

The current behavior is that the documentation provides an incorrect code sample using the notifications provider from the Ant Design UI package instead of the Material UI notifications provider.

What is the new behavior?

The new behavior is that the documentation code sample is updated to import and use the Material UI notifications provider from @refinedev/mui as recommended.

fixes #5620 (issue)

Notes for reviewers No additional notes. Everything should be straightforward.

Mohamed-khattab avatar Feb 10 '24 02:02 Mohamed-khattab

⚠️ No Changeset found

Latest commit: e9d870c7c50a6ec0230c485922c64bfb4787b8c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 10 '24 02:02 changeset-bot[bot]

LGTM, thanks for the quick turnaround!

BenMusch avatar Feb 11 '24 14:02 BenMusch

Sorry, I missed this detail. I've committed the changes to switch to useNotificationProvider as you suggested. Thanks

Mohamed-khattab avatar Feb 12 '24 11:02 Mohamed-khattab