refine
refine copied to clipboard
refinedev
feat(core): added custom optionLabel
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention
Bugs / Features
- [x] Related issue(s) linked
- [x] Tests for the changes have been added
- [ ] Docs have been added / updated
- [x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset
What is the current behavior?
What is the new behavior?
fixes #4880
Notes for reviewers
‼️ If provided changes meet the required changes than I should go further with docs. ‼️
🦋 Changeset detected
Latest commit: 13c3e48abdb0013aa9610a659a3a956f94c2d382
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 13c3e48abdb0013aa9610a659a3a956f94c2d382. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 73 targets
lerna run cypress:run --scope with-remix-material-ui -- --record --key --group with-remix-material-uilerna run cypress:run --scope with-remix-headless -- --record --key --group with-remix-headlesslerna run cypress:run --scope with-remix-antd -- --record --key --group with-remix-antdlerna run cypress:run --scope with-nextjs-next-auth -- --record --key --group with-nextjs-next-authlerna run cypress:run --scope with-nextjs -- --record --key --group with-nextjslerna run cypress:run --scope table-react-table-basic -- --record --key --group table-react-table-basiclerna run cypress:run --scope table-react-table-advanced -- --record --key --group table-react-table-advancedlerna run cypress:run --scope table-material-ui-use-update-many -- --record --key --group table-material-ui-use-update-manylerna run cypress:run --scope table-material-ui-use-delete-many -- --record --key --group table-material-ui-use-delete-manylerna run cypress:run --scope table-material-ui-use-data-grid -- --record --key --group table-material-ui-use-data-gridlerna run cypress:run --scope table-material-ui-table-filter -- --record --key --group table-material-ui-table-filterlerna run cypress:run --scope table-material-ui-data-grid-pro -- --record --key --group table-material-ui-data-grid-prolerna run cypress:run --scope table-material-ui-cursor-pagination -- --record --key --group table-material-ui-cursor-paginationlerna run cypress:run --scope table-material-ui-advanced -- --record --key --group table-material-ui-advancedlerna run cypress:run --scope table-mantine-basic -- --record --key --group table-mantine-basiclerna run cypress:run --scope table-mantine-advanced -- --record --key --group table-mantine-advancedlerna run cypress:run --scope form-material-ui-mutation-mode -- --record --key --group form-material-ui-mutation-modelerna run cypress:run --scope table-handson -- --record --key --group table-handsonlerna run cypress:run --scope table-chakra-ui-basic -- --record --key --group table-chakra-ui-basiclerna run cypress:run --scope form-mantine-use-steps-form -- --record --key --group form-mantine-use-steps-formlerna run cypress:run --scope table-chakra-ui-advanced -- --record --key --group table-chakra-ui-advancedlerna run cypress:run --scope table-antd-use-update-many -- --record --key --group table-antd-use-update-manylerna run cypress:run --scope form-mantine-use-modal-form -- --record --key --group form-mantine-use-modal-formlerna run cypress:run --scope table-antd-use-table -- --record --key --group table-antd-use-tablelerna run cypress:run --scope table-antd-use-editable-table -- --record --key --group table-antd-use-editable-tablelerna run cypress:run --scope table-antd-use-delete-many -- --record --key --group table-antd-use-delete-manylerna run cypress:run --scope table-antd-table-filter -- --record --key --group table-antd-table-filterlerna run cypress:run --scope auth-keycloak -- --record --key --group auth-keycloaklerna run cypress:run --scope table-antd-advanced -- --record --key --group table-antd-advancedlerna run cypress:run --scope form-mantine-use-form -- --record --key --group form-mantine-use-formlerna run cypress:run --scope auth-headless -- --record --key --group auth-headlesslerna run cypress:run --scope server-side-form-validation-material-ui -- --record --key --group server-side-form-validation-material-uilerna run cypress:run --scope auth-google-login -- --record --key --group auth-google-loginlerna run cypress:run --scope server-side-form-validation-mantine -- --record --key --group server-side-form-validation-mantinelerna run cypress:run --scope form-antd-use-form -- --record --key --group form-antd-use-formlerna run cypress:run --scope auth-chakra-ui -- --record --key --group auth-chakra-uilerna run cypress:run --scope server-side-form-validation-chakra-ui -- --record --key --group server-side-form-validation-chakra-uilerna run cypress:run --scope form-mantine-use-drawer-form -- --record --key --group form-mantine-use-drawer-formlerna run cypress:run --scope form-antd-use-drawer-form -- --record --key --group form-antd-use-drawer-formlerna run cypress:run --scope auth-auth0 -- --record --key --group auth-auth0lerna run cypress:run --scope server-side-form-validation-antd -- --record --key --group server-side-form-validation-antdlerna run cypress:run --scope inferencer-material-ui -- --record --key --group inferencer-material-uilerna run cypress:run --scope form-antd-mutation-mode -- --record --key --group form-antd-mutation-modelerna run cypress:run --scope auth-antd -- --record --key --group auth-antdlerna run cypress:run --scope form-chakra-use-modal-form -- --record --key --group form-chakra-use-modal-formlerna run cypress:run --scope form-antd-custom-validation -- --record --key --group form-antd-custom-validationlerna run cypress:run --scope inferencer-mantine -- --record --key --group inferencer-mantinelerna run cypress:run --scope form-chakra-ui-use-form -- --record --key --group form-chakra-ui-use-formlerna run cypress:run --scope data-provider-supabase -- --record --key --group data-provider-supabaselerna run cypress:run --scope base-material-ui -- --record --key --group base-material-uilerna run cypress:run --scope form-mantine-mutation-mode -- --record --key --group form-mantine-mutation-modelerna run cypress:run --scope form-chakra-ui-use-drawer-form -- --record --key --group form-chakra-ui-use-drawer-formlerna run cypress:run --scope base-mantine -- --record --key --group base-mantinelerna run cypress:run --scope inferencer-headless -- --record --key --group inferencer-headlesslerna run cypress:run --scope data-provider-strapi-v4 -- --record --key --group data-provider-strapi-v4lerna run cypress:run --scope form-chakra-ui-mutation-mode -- --record --key --group form-chakra-ui-mutation-modelerna run cypress:run --scope inferencer-graphql-hasura -- --record --key --group inferencer-graphql-hasuralerna run cypress:run --scope form-react-hook-form-use-modal-form -- --record --key --group form-react-hook-form-use-modal-formlerna run cypress:run --scope base-chakra-ui -- --record --key --group base-chakra-uilerna run cypress:run --scope form-antd-use-steps-form -- --record --key --group form-antd-use-steps-formlerna run cypress:run --scope base-antd -- --record --key --group base-antdlerna run cypress:run --scope inferencer-chakra-ui -- --record --key --group inferencer-chakra-uilerna run cypress:run --scope form-react-hook-form-use-form -- --record --key --group form-react-hook-form-use-formlerna run cypress:run --scope form-antd-use-modal-form -- --record --key --group form-antd-use-modal-formlerna run cypress:run --scope form-material-ui-use-steps-form -- --record --key --group form-material-ui-use-steps-formlerna run cypress:run --scope auth-material-ui -- --record --key --group auth-material-uilerna run cypress:run --scope form-material-ui-use-modal-form -- --record --key --group form-material-ui-use-modal-formlerna run cypress:run --scope inferencer-antd -- --record --key --group inferencer-antdlerna run cypress:run --scope auth-mantine -- --record --key --group auth-mantinelerna run cypress:run --scope form-material-ui-use-form -- --record --key --group form-material-ui-use-formlerna run cypress:run --scope form-save-and-continue -- --record --key --group form-save-and-continuelerna run cypress:run --scope form-material-ui-use-drawer-form -- --record --key --group form-material-ui-use-drawer-formlerna run cypress:run --scope form-react-hook-form-use-steps-form -- --record --key --group form-react-hook-form-use-steps-form
Sent with 💌 from NxCloud.
![nx-cloud[bot] avatar](https://avatars.githubusercontent.com/in/80458?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @Conqxeror thanks for the PR with great description as always!
Let's do the implementation according to the comment here: https://github.com/refinedev/refine/issues/4880#issuecomment-1742600902
optionValue and optionLabel params are currently string only, let's make each of them a union of string or function. And invoke the given function with item as in your implementation.
It would be amazing to implement similar changes for similar hooks other than @refinedev/core's useSelect.
@refinedev/antd has following hooks which can be refactored in a similar way:
- useSelect
- useRadioGroup
- useCheckboxGroup
Hey @Conqxeror thanks for the PR with great description as always!
Let's do the implementation according to the comment here: #4880 (comment)
optionValueandoptionLabelparams are currently string only, let's make each of them a union of string or function. And invoke the given function withitemas in your implementation.It would be amazing to implement similar changes for similar hooks other than
@refinedev/core'suseSelect.
@refinedev/antdhas following hooks which can be refactored in a similar way:
- useSelect
- useRadioGroup
- useCheckboxGroup
Thanks, @BatuhanW ! Your feedback is always appreciated. I always find your reviews great! I'll update optionValue and optionLabel as per the comment in #4880 (comment). Also, extending these changes to @refinedev/antd's useSelect, useRadioGroup, and useCheckboxGroup sounds great.
Hello @BatuhanW I wanted to know if all the required changes are satisfied or not. If so then I can go further with the docs.
Review it whenever you are free, its okay if you take time.