refine icon indicating copy to clipboard operation
refine copied to clipboard

[BUG] Table representation is broken in `Data Fetching` guide

Open alicanerdurmaz opened this issue 1 year ago • 17 comments

Describe the bug

The table representation within the relationship section of the data-fetching documentation looks broken.

Steps To Reproduce

  1. Go to https://refine.dev/docs/guides-concepts/data-fetching/#relationships
  2. Look at the table representation.

Expected behavior

Borders should be aligned.

Screenshot

image

alicanerdurmaz avatar Jan 11 '24 13:01 alicanerdurmaz

I believe it's already aligned, working fine for me @alicanerdurmaz

Screenshot from 2024-01-12 03-37-15

amirk85 avatar Jan 11 '24 22:01 amirk85

I believe it's already aligned, working fine for me @alicanerdurmaz

Screenshot from 2024-01-12 03-37-15

If you check out the docs you can see the borders are misaligned. In my vscode it also appeared fine but for some reason in the docs it's weird.

AnasGrzor avatar Jan 11 '24 22:01 AnasGrzor

@AnasGrzor not able to see the screenshot you attached. And also I don't see any misalignment in the doc as well

attaching a short clip

Screencast from 12-01-24 04:09:05 AM IST.webm

amirk85 avatar Jan 11 '24 22:01 amirk85

@amirk85 Screenshot_2024-01-12-03-45-48-050_com android chrome This is in chrome

AnasGrzor avatar Jan 11 '24 22:01 AnasGrzor

Hello @AnasGrzor and @amirk85, thanks for helping Refine.

It's an interesting problem 🤔. I will investigate too.

alicanerdurmaz avatar Jan 12 '24 07:01 alicanerdurmaz

Hey everyone, thank you for your interests and effort in this issue! I've suspected that this is happening due to fallbacks provided in the font family definition. I've checked in my local to update the tailwind.config.js like this for the JetBrains Mono:

"jetBrains-mono": [
                    "JetBrains Mono",
-                   ...defaultTheme.fontFamily.mono,
+                   "monospace"
                ],

The issue resolved for me.

Can anyone check if the same solution works for them as well? If its resolved, we'll be happy to see a PR addressing this change 🙏

aliemir avatar Jan 12 '24 07:01 aliemir

image I did the change but it's still the same image

AnasGrzor avatar Jan 12 '24 10:01 AnasGrzor

It is caused by font-family: Source Code Pro @aliemir @BatuhanW @alicanerdurmaz

With Font :

SS for issue.

Screenshot 2024-01-17 112148

Reason for issue.

Screenshot 2024-01-17 112203

Without Font

Issue Fix If:

Screenshot 2024-01-17 112751

After removal of: font-family: Source Code Pro :

Screenshot 2024-01-17 112819

Conqxeror avatar Jan 17 '24 06:01 Conqxeror

Is the issue resolved? If not, I'm excited to work on resolving it.

notnick2 avatar Jan 21 '24 12:01 notnick2

@notnick2 Thanks 🚀, I assigned the issue to you.

alicanerdurmaz avatar Jan 22 '24 14:01 alicanerdurmaz

Hi @alicanerdurmaz , has this issue been fixed already? If not, can I fix it?

CodeKage25 avatar Feb 06 '24 07:02 CodeKage25

@CodeKage25 Thanks, I assigned it to you.

alicanerdurmaz avatar Feb 06 '24 07:02 alicanerdurmaz

@alicanerdurmaz Hey Alican, may I have a go at this? A little occupied in the next 4 days. Will work on it roughly mid of next week or ASAP. If you're okay with it!

domlimm avatar Mar 09 '24 14:03 domlimm

Hey @domlimm let us know when you can work on this, let's assign to you.

BatuhanW avatar Mar 12 '24 12:03 BatuhanW

@BatuhanW Hey Bathuan! I did some digging last week and just for an hour before writing this.. Seems okay on VSCode (but I suppose that's not the case/what we're trying to fix). However, I checked on prod and it seems slightly off. I'm on macOS, checked on Chrome.

VSCode: image

Chrome: image

Safari: image

On Windows Chrome (both locally and prod): Exactly what's shown in the opening of this issue.

I am actually struggling to find out the root cause. It's odd because it's a table in markdown.

domlimm avatar Mar 22 '24 03:03 domlimm

There's a lot of hands working on this issue. If there is anything that I can do to help, please let me know. Otherwise I'll continue to look for another issue to work on. FWI worth, I am new to this repo.

JamieBort avatar Mar 25 '24 22:03 JamieBort

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 24 '24 22:05 stale[bot]