refine icon indicating copy to clipboard operation
refine copied to clipboard

fix(chakra-ui): resolve sider issue #5475

Open ShivamDureja opened this issue 1 year ago • 9 comments

Issue Fixed: [Chakra UI Sider overflows when collapsed #5475]

Description:

  • Resolved the issue where the Chakra UI Sider was overflowing when collapsed.
  • Adjusted the styles to prevent horizontal overflow when the Sider is in a collapsed state.

Changes Made:

Self Check before Merge

Please check all items below before review.

  • [x] Corresponding issues are created/updated or not needed
  • [x] Docs are updated/provided or not needed
  • [x] Examples are updated/provided or not needed
  • [x] TypeScript definitions are updated/provided or not needed
  • [x] Tests are updated/provided or not needed
  • [x] Changesets are provided or not needed

ShivamDureja avatar Jan 04 '24 16:01 ShivamDureja

🦋 Changeset detected

Latest commit: fe516c2439c2303916fc0aa4a3ccd2472e445188

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 04 '24 16:01 changeset-bot[bot]

@ShivamDureja Thanks for the PR 🚀

Can you write a changeset please?

alicanerdurmaz avatar Jan 05 '24 06:01 alicanerdurmaz


"@refinedev/refine/packages/chakra-ui": patch

fix: issue with Chakra-UI sider that overflows when collapsed

When we try to collapse the sider it overflows so changed overflow-x property to hidden whereas overflow-y remains auto.

It is expected to improve the user interface and resolve the mentioned bug.

Issue : [https://github.com/refinedev/refine/issues/5475]
PR raised : [https://github.com/refinedev/refine/pull/5480]

ShivamDureja avatar Jan 05 '24 08:01 ShivamDureja

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ff80f562db8dfdc62645f86f69492c9b250f9335. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 83 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jan 09 '24 07:01 nx-cloud[bot]

Hello, @ShivamDureja

changeset should be a markdown file in the Refine repo.

You can read changeset documentation to learn how to use and why Refine uses them.

alicanerdurmaz avatar Jan 09 '24 07:01 alicanerdurmaz

Hi @alicanerdurmaz , for that Do I need raise PR again?

ShivamDureja avatar Jan 09 '24 10:01 ShivamDureja

Hi @alicanerdurmaz , for that Do I need raise PR again?

You can commit the changeset file to this PR

alicanerdurmaz avatar Jan 09 '24 10:01 alicanerdurmaz

Thanks @alicanerdurmaz , can you please verify.

ShivamDureja avatar Jan 09 '24 11:01 ShivamDureja

Thanks @alicanerdurmaz , can you please verify.

Thanks! But, can you remove one of them, please? We don't want to increment the version twice. image

alicanerdurmaz avatar Jan 10 '24 06:01 alicanerdurmaz