refine
refine copied to clipboard
fix(simple-rest): fix generated url with query string
fix: dataProvider.getList
method adds ?
to the request url when there is no filters
, sorters
and pagination
in the request. #5359
- Expected
+ Received
- "https://api.fake-rest.refine.dev/categories",
+ "https://api.fake-rest.refine.dev/categories?",
From now on, dataProvider.getList
method will not add ?
to the request url when there is no filters
, sorters
and pagination
in the request.
Test plan (required)
Closing issues
closes #5359
Self Check before Merge
Please check all items below before review.
- [x] Corresponding issues are created/updated or not needed
- [x] Docs are updated/provided or not needed
- [x] Examples are updated/provided or not needed
- [x] TypeScript definitions are updated/provided or not needed
- [x] Tests are updated/provided or not needed
- [x] Changesets are provided or not needed
🦋 Changeset detected
Latest commit: 3f19850182003e4107edd759e360d6fa4de7ac0e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 949c59384e44820b9343cf0ef1d54f60563cb855. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
I've added. Could you check @BatuhanW
@BatuhanW I've also updated the fn implementation here
@BatuhanW I've also updated the fn implementation here
Thanks @amanzrx4! Looks great! We'll review it soon! Assigned it to January release.
There are 2 minor updates:
- Add a test for the new utility file
- Add new file to
refine.config.js
. https://github.com/refinedev/refine/blob/7c8827b43d9e378818be6ee23032925c97ce02d5/packages/simple-rest/refine.config.js#L18
We need to add this file to refine.config.js
, because if someone swizzles this data provider, it won't copy this file to users' directory.