refine icon indicating copy to clipboard operation
refine copied to clipboard

[BUG] Not reset filter when side bar click

Open KoYoungWock opened this issue 1 year ago • 7 comments

Describe the bug

Hi

I encountered an issue while running the Mantine Advance Filter Example Project provided in Refine. When I click on a filter, the filter values are applied to the URL parameters as expected. However, when I click on the Sidebar, the URL parameters disappear, but the actual filter values are not reset.

Steps To Reproduce

Encountered an issue in the Mantine Advance Filter Example Project in Refine. When I click on a filter, the filter values are correctly applied to the URL parameters. However, when I click on the Sidebar, the URL parameters disappear, but the actual filter values are not reset. I plan to create a GitHub issue to address this problem.

Expected behavior

The expected behavior, in fact, is that when you apply filter values in the List and then click on the Sidebar, the filter values should reset.

Screenshot

https://github.com/refinedev/refine/assets/134250452/277445eb-0b9c-42ca-bf4d-9d291e020fad

Desktop

  • OS Ventura 13.3(22E252)
"@refinedev/mantine": "^2.28.2",
"@refinedev/core": "^4.36.0",
"@refinedev/cli": "^2.9.0",
"@refinedev/react-router-v6": "^4.5.0",
"@refinedev/simple-rest": "^4.5.0",
"@refinedev/react-table": "^5.6.0",
"@tanstack/react-table": "^8.2.6",

Mobile

No response

Additional Context

No response

KoYoungWock avatar Nov 09 '23 01:11 KoYoungWock

Hello @KoYoungWock thanks for the detailed report. We are open to contributions for this issue.

Note for future contributors: You can find reproducible example here: https://refine.dev/docs/examples/table/mantine/basic/

BatuhanW avatar Nov 09 '23 08:11 BatuhanW

@BatuhanW Thank you for your answer! I'll try the method you taught me!

KoYoungWock avatar Nov 14 '23 01:11 KoYoungWock

Hi @BatuhanW , Can you please assign this issue to me?

Ponnada96 avatar Nov 14 '23 10:11 Ponnada96

In my opinion need to make changes in routerProvider bindings i.e. https://github.com/refinedev/refine/blob/master/packages/react-router-v6/src/bindings.tsx

aniruddhha avatar Nov 15 '23 16:11 aniruddhha

@BatuhanW @omeraplak can you please assign this issue to me also ?

aniruddhha avatar Nov 24 '23 08:11 aniruddhha

Hello @aniruddhha, assigned 🚀 Looking forward to your contribution. 🙌🏼

BatuhanW avatar Nov 24 '23 09:11 BatuhanW

@BatuhanW Can you plz assign this issue to me also?

shivam-raj03 avatar Dec 29 '23 12:12 shivam-raj03

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 27 '24 13:02 stale[bot]