refine icon indicating copy to clipboard operation
refine copied to clipboard

WIP: fix #3451,#3452

Open jsbrain opened this issue 1 year ago • 3 comments

I'm having trouble to build the project and run the test so I'm gonna leave this up to you.

This PR fixes the references issues. Probably need some refinement but I think most of it should just work.

Obviously all @supabase/supabase-js dependencies need to be upgraded as well but as v2 has been released almost 3 months ago that's the right way to move forward anyways I guess.

Test plan (required)

Demonstrate the code is solid. If not, please add WIP: in its title.

Closing issues

closes #3451,#3452

Self Check before Merge

Please check all items below before review.

  • [ ] Corresponding issues are created/updated or not needed
  • [ ] Docs are updated/provided or not needed
  • [ ] Examples are updated/provided or not needed
  • [ ] TypeScript definitions are updated/provided or not needed
  • [ ] Tests are updated/provided or not needed
  • [ ] Changesets are provided or not needed

jsbrain avatar Jan 24 '23 09:01 jsbrain

⚠️ No Changeset found

Latest commit: 8d039d85881bf9075c0b665a4c9f5af3f3fd0d8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 24 '23 09:01 changeset-bot[bot]

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
Latest commit 8d039d85881bf9075c0b665a4c9f5af3f3fd0d8f
Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/63cfa7798c2fae000857e762
Deploy Preview https://deploy-preview-3453--refine-doc-live-previews.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jan 24 '23 09:01 netlify[bot]

Hi @jsbrain, thank you for PR 🙏

can you provide changeset please?

alicanerdurmaz avatar Jan 24 '23 11:01 alicanerdurmaz

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8d039d85881bf9075c0b665a4c9f5af3f3fd0d8f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
lerna run test --stream --scope @pankod/refine* --scope create-refine-app
✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jan 27 '23 07:01 nx-cloud[bot]

Hey @jsbrain

Thank you for the contribution 🚀 Everything looks fine, but we have many example applications with supabase. We need to test them and check for backward compatibility. I will do this and let you know.

We are also waiting for a changeset. Do you need help with this?

yildirayunlu avatar Jan 27 '23 09:01 yildirayunlu

Thank you for the effort @jsbrain 🙏 We needed to make some additional changes and moved the progress to #3528. We'd love to hear your feedback and see your review to the PR. Thanks again for the PR and for your contribution to refine! 🥇

yildirayunlu avatar Feb 07 '23 14:02 yildirayunlu