refine icon indicating copy to clipboard operation
refine copied to clipboard

feat: custom index route

Open aliemir opened this issue 3 years ago • 5 comments

Added indexRoute property to options of <Refine/> component to manage initial route of the app if users wants to change that from first resource's route to something else.

Test plan (required)

Passing other than a react-query issue in the next.

Closing issues

Resolves #1285 #2544 #2545 #2546

Self Check before Merge

Please check all items below before review.

  • [x] Corresponding issues are created/updated or not needed
  • [ ] Docs are updated/provided or not needed
  • [x] Examples are updated/provided or not needed
  • [x] TypeScript definitions are updated/provided or not needed
  • [x] Tests are updated/provided or not needed
  • [x] Changesets are provided or not needed

aliemir avatar Sep 12 '22 10:09 aliemir

🦋 Changeset detected

Latest commit: d2f9922ca51b13b3c97a1722364628915e892c81

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 12 '22 10:09 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d2f9922ca51b13b3c97a1722364628915e892c81:

Sandbox Source
fine-foods Configuration
fine-foods-client Configuration
mui-fine-foods Configuration

codesandbox-ci[bot] avatar Sep 12 '22 10:09 codesandbox-ci[bot]

🎖️

omeraplak avatar Sep 12 '22 10:09 omeraplak

How is it if we rename "openingRoute", "landingPage" or "startupPage" instead of "indexRoute". "indexRoute" name doesn't explain itself well enough.

salihozdemir avatar Sep 12 '22 11:09 salihozdemir

We'll move the option to routerProvider functions and rename it to defaultRoute if everyone agrees.

aliemir avatar Sep 12 '22 22:09 aliemir