refine icon indicating copy to clipboard operation
refine copied to clipboard

fix(sider): set menu theme to dark matching antd sider default theme

Open dgonsan opened this issue 3 years ago • 4 comments

This PR is related to issue #1862. Applying this change makes the default menu provided by Refine that is inside a Sider element to match the default AntD theme set to the Sider, dark.

With this change is possible to switch to a default AntD stylesheet without breaking the menu.

The changes in the refine stylesheet ensure that the current look and feel is maintained after changing the menu theme.

dgonsan avatar Jun 01 '22 15:06 dgonsan

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0986f0a0f2e9d84fe1f0675318fe51fc59f9f456:

Sandbox Source
pankod/refine Configuration
pankod/refine Configuration

codesandbox-ci[bot] avatar Jun 01 '22 15:06 codesandbox-ci[bot]

⚠️ No Changeset found

Latest commit: 0986f0a0f2e9d84fe1f0675318fe51fc59f9f456

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 01 '22 15:06 changeset-bot[bot]

Hello @dgonsan, Thank you for the PR.

Could you add your changes custom-theme.less file instead of style.min.css. Then, you have to run npm run generate-theme script in packages/antd folder for update style.min.css file.

salihozdemir avatar Jun 02 '22 09:06 salihozdemir

Hi @salihozdemir ,

Changed the less file and generated a new css from it.

dgonsan avatar Jun 02 '22 12:06 dgonsan

Hey @dgonsan , We fixed this issue with ant design v5. Thanks a lot for your understanding ❤️

omeraplak avatar Dec 20 '22 10:12 omeraplak