refined-github icon indicating copy to clipboard operation
refined-github copied to clipboard

Show number of disabled features on extension options page

Open injust opened this issue 1 year ago • 4 comments

Description

Screenshot 2024-07-15 at 7 11 01 PM

could look like

Screenshot 2024-07-15 at 7 11 19 PM

Example URLs

chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/options.html

injust avatar Jul 15 '24 23:07 injust

That number is actually an approximation because it also includes a CSS features, both standalone and small fixes in refined-github.css

Since being exact with this count would make it verbose, I'd rather not, also because I hope people won't disable more than handful anyway.

fregante avatar Jul 16 '24 02:07 fregante

Your explanation makes sense! I don't want to complicate things just for this minor change.

Just some colour for why I requested this:

I recently installed the extension, and occasionally want to compare a Refined GitHub feature to the original behaviour. There's a few ways to do this:

  1. Disable all the features from the extension options (this takes a few clicks because the button is hidden under "Identify feature" and then "Toggle all features...", which also makes it a bit hard to find)
  2. Disable the extension entirely (this is unfortunately what I ended up doing, but it works!)
  3. Use the Identify feature button (the binary search is awesome, but way too many clicks for this simple purpose)

When I was still doing 1), sometimes I would forget if I had re-enabled all the features. So I'd go into the extension options to check...but there's no visual feedback for that. So I'd just click those 3 buttons again to make sure all the features were enabled. That's a lot of clicks just to be sure!

injust avatar Jul 17 '24 17:07 injust

"Toggle all features" is hidden specifically because it's the nuclear option and it has drawbacks like these. I don’t think adding a counter would be beneficial here.

I think every variation of that is already possible:

  • you want to see the whole native GitHub:
    • you disable the extension and re-enable it; It already works, it requires no effort on our part, and it's completely safe (no configuration loss like you get with point 1)
  • you want to see the native version of single feature:
    • you disable the single feature
  • you don't know what's affecting the page:
    • disable the extension
    • use "identify feature"

fregante avatar Jul 17 '24 17:07 fregante

Reopening, the counter can be implemented for the number of features disabled (including hotfixes)

Features: 216 (1 off)

fregante avatar Jul 17 '24 17:07 fregante