refined-github icon indicating copy to clipboard operation
refined-github copied to clipboard
verified publisher icon refined-github

`hide-user-forks`: breaks browsing org repos

Open keysmashes opened this issue 2 years ago • 2 comments

Description

When you click on the "Repositories" tab for an org, or hit "View all repositories" at the bottom of the page, you get taken to a page like https://github.com/orgs/NixOS/repositories?type=source (hide-user-forks adds the ?type=source). There's a "Clear filter" button, and clicking it removes the filter (e.g. takes you to https://github.com/orgs/NixOS/repositories), but the pagination buttons at the bottom will reapply the filter (e.g. linking to https://github.com/orgs/NixOS/repositories?page=2&type=source), which makes it very annoying to page through all repos owned by an org.

How to replicate the issue + URL

  1. Visit https://github.com/NixOS
  2. Click "View all repositories"
  3. Click "Clear filter"
  4. Click "Next" (to go to page 2)
  5. Observe that the filter is silently reapplied

Extension version

23.12.17

Browser(s) used

Chrome 120.0.6099.109

keysmashes avatar Dec 20 '23 22:12 keysmashes

You're right we should exclude the navigation. We have similar logic in sort-conversations-by-update-time

https://github.com/refined-github/refined-github/blob/cf69a82b38ae7e18563a195d8d45e63e83d7ebd5/source/features/sort-conversations-by-update-time.tsx#L27

fregante avatar Dec 21 '23 00:12 fregante

hi

metaqer avatar Dec 22 '23 05:12 metaqer

They added a new view in beta, there's no "clear filter" and the navigation works as expected:

Untitled

fregante avatar Jun 04 '24 08:06 fregante