refined-github icon indicating copy to clipboard operation
refined-github copied to clipboard

`sync-pr-commit-title` - "Cancel" requires two clicks

Open fregante opened this issue 2 years ago • 1 comments

Description

I don’t think this is caused by us, but probably there's an event listener that cancels propagation so our delegate() never receives the event:

https://github.com/refined-github/refined-github/assets/1402241/ff3c3394-5f3b-4c63-b33b-d58347d9d412

It seems to be related with the focus of the field, because if I blur it first, it works with one click. This is also true when blurring via tab

https://github.com/refined-github/refined-github/assets/1402241/823d11a3-626e-4810-b0a9-a269eb4a624f

How to replicate the issue + URL

https://github.com/refined-github/sandbox/pull/12

Extension version

23.11.3, 23.11.15

Browser(s) used

Chrome, Safari

fregante avatar Nov 23 '23 06:11 fregante

I tried capture: true here but that was not enough.

https://github.com/refined-github/refined-github/blob/927bca4ecfe486183df1c0d8a07cb336dcdf14b2/source/features/sync-pr-commit-title.tsx#L92-L93

fregante avatar Nov 23 '23 06:11 fregante