refined-github
refined-github copied to clipboard
Can't add labels to PRs or issues that lack labels when Refined Github is enabled
Description
When Refined GitHub is enabled, clicking on Labels (or the corresponding gear icon) does nothing:

When I disable Refined GitHub, clicking on Labels shows the Labels dropdown:
I've confirmed with my coworkers who also use Refined GitHub that labels were working yesterday.
I see that yesterday the 22.7.20 release was pushed: https://github.com/refined-github/refined-github/releases/tag/22.7.20 could this be a regression in the latest release?
How to replicate the issue
Open a PR or issue which:
- you have permission to add labels to
- has no existing labels
For me https://github.com/3rdparty/eventuals/issues/483 reproduces this (since it has no labels and I have permission to add labels) but https://github.com/3rdparty/eventuals/issues/456 does not (I have permission, but when there are existing labels the labels modal works correctly)
Extension version
22.7.20
Browser(s) used
Chrome
Feature bisector points to clean-conversation-sidebar
being the culprit.
@CodingCanuck You can disable that specific feature until this is fixed :slightly_smiling_face:
Feature bisector points to
clean-conversation-sidebar
being the culprit.@CodingCanuck You can disable that specific feature until this is fixed 🙂
Confirmed: disabling that feature is a workaround for this issue.
That feature points to https://github.com/refined-github/refined-github/pull/5777/files as a potential culprit, could that be the regression?
I'm not familiar with this code, but I'm suspicious of the >
being dropped from the line under // Hide heading in any case except `canEditSidebar\`
I disabled it via hotfix again, we had just fixed it