refi64
added assetId to assets
I added the assetId to assets as discussed in https://github.com/refi64/aspen/issues/2
There is now an AssetData class which is now required in the constructor of the -Asset-classes. I didn't make the parameters optional as I don't know if there is a case where you'd want to create an Asset manually (except for that aspen_playground-package).
I don't know how you handle the versioning of the aspen package, as there is no breaking change and only the README.md needed an update. I've set the version of the other packages to 0.4.0.
I've also added tests for the BundleGenerator.
Sorry the huge review delays!
I don't know how you handle the versioning of the aspen package, as there is no breaking change and only the README.md needed an update. I've set the version of the other packages to 0.4.0.
~~Was it intentional you put the assetId change in here? That one's definitely breaking and also unrelated to the PR.~~ Ignore that I misread. That's definitely a big breaking change though, the assets are pretty much always constructed manually.
For the versioning, I guess I usually leave it as-is until the next release.
That's why I asked. As aspen itself only contains the annotation, which didn't change. But if you do the versioning right before releasing, I guess everything is fine then and I don't need to change anything in that regard as you'll do it the way you prefer it. And no problem for you taking your time reviewing, I've been using it as a path dependency for a while and I don't mind.