cloaks icon indicating copy to clipboard operation
cloaks copied to clipboard

feature/minPrice-reveal

Open shortdoom opened this issue 3 years ago • 0 comments

Relevant: https://github.com/abigger87/cloaks/issues/11

Added priceReveal function allowing deployer to reveal minimum price after reveal phase passes. Includes few basic tests.

Needed to allow for one step higher code complexity in solc to implement additional check in mint() for existence (or lack of) minPrice setting.

Highly opinionated. I think priceReveal would work better as an extension as is somehow breaks minimal commit-reveal scheme. I tried to not add any additional variables/functions at all cost what resulted in some security tradeoffs e.g deployer minPrice commit being stored with other users mint commits.

First time ever using foundry thanks to this repo.

shortdoom avatar Feb 11 '22 18:02 shortdoom