Bootstrap 4 support

[mattez]

Bootstrap 4 support?

[acrobat]

I guess that is something the library should support, but bootstrap 4 is currently in alpha. We can start on it when it reaches beta as from then on there will be no api changes!

[mattez]

Great. Thanx for reply. (Anyway: I`m going to try it...if it works without changes.)

[acrobat]

I think the classnames will change a bit, but please try it and give us some feedback! You can also start a PR to add BS4 support

[toopay]

:+1:

[mattez]

First observation: Bootstrap 4 dropped Glyphicon support. So there no icons but buttons works fine:

[blackfyre]

Second observation: Bootstrap has dropped the hidden class due to incompatibility with jquery's show(), hide() methods.

[Magicalex]

To hide an element, you need to use attribute hidden. http://v4-alpha.getbootstrap.com/content/reboot/#html5-hidden-attribute

ex: <button class="btn-sm btn btn-primary" hidden>button</button>

[itsmill3rtime]

i haven't really had any issues with bootstrap4. the only thing i had to do was add iconlibrary: 'fa' as a parameter

[toopay]

Thanks guys. I'll try to conduct wider test this week.

[LucileDT]

Hi! @toopay is there any news? I would like to use this project but we are using Bootstrap4 since it's stable :)

[NicolasCARPi]

Note that in order to play well with fontawesome5 if you do treeshaking one needs to edit bootstrap-mardown.js and replace line 1003 fa-header by fa-heading, line 1070 fa-picture-o by fa-image.

Maybe we can have a 'fa-5' option to deal with this situation?

As for bootstrap4 everything looks fine. As @itsmill3rtime said, one needs to explicitly call the plugin on the element to add the iconlibrary: 'fa' option.

Cheers :)

[lodev09]

the way this is done normally is we bump a major version to the plugin, create a branch for the current BS 3 support (2.x) and then put BS4 support in master (3.x)

[niknokseyer]

The default glyphicon icon doesn't load. Will try FontAwesome.

[hangya]

Note that in order to play well with fontawesome5 if you do treeshaking one needs to edit bootstrap-mardown.js and replace line 1003 fa-header by fa-heading, line 1070 fa-picture-o by fa-image.

You can fix the missing icons using fontawesome5 by adding this two lines to your css, so you do not need to alter the javascript:

.fa-header::before { content: "\f1dc"; }
.fa-picture-o::before { content:"\f03e"; }