Matthew Ramsden

Results 118 comments of Matthew Ramsden

> Thanks for testing, and it makes sense to do further testing to confirm working order. > > I made the PR rather quickly without much testing. I'm glad you...

excellent job my friend!

Updated PR due to great feedback from Evan, Mammal, Leonardo. Noteworthy: - Introduced a crate-wide Error enum (in lib.rs) with Client and Checkpoint variants. Both async and blocking extensions now...

I believe all review comments are addressed now; to recap current state this PR adds logic around removing panic tied to remote input, while leaving panics where appropriate based on...

> ACK [d4244e3](https://github.com/bitcoindevkit/bdk/commit/d4244e315017dfe570220f34f75b34e60a7fa8dd) > > Note: I think it would make sense to use `gap_limit = stop_gap.max(parallel_requests)`. Related discussion [#2053 (comment)](https://github.com/bitcoindevkit/bdk/pull/2053#discussion_r2407422581) and [bitcoindevkit/bdk_wallet#63](https://github.com/bitcoindevkit/bdk_wallet/issues/63). @ValuedMammal I just updated PR to use...

> This is a bit of a blocker for the 2.3 release of bdk-ffi, I'd like to include it in there if possible. @reez do you mind trying the pin...

> #2080 Thanks for the heads up! I'll try to keep an eye on that PR so when it gets merged I can rebase this PR on it if needed...

> > #2080 > > Thanks for the heads up! > > I'll try to keep an eye on that PR so when it gets merged I can rebase this...