Monday icon indicating copy to clipboard operation
Monday copied to clipboard

spm: ldk-node local main

Open reez opened this issue 10 months ago • 1 comments

Description

Playing around with Expose Node status and statistics.

Notes to the reviewers

Using local build of ldk-node at commit 71b1d3c of main.

Kind of undoes all of the things I did in spm: ldk-node version (I'm assuming all of those make their way back into ldk-node main eventually?) but for now I wanted to play around with Expose Node status and statistics which was only available on main.

Changelog notice

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I have formatted my code with swift-format per .swift-format file

New Features:

  • [ ] I've added tests for the new feature
  • [ ] I've added docs for the new feature

Bugfixes:

  • [ ] This pull request breaks the existing API
  • [ ] I've added tests to reproduce the issue which are now passing
  • [ ] I'm linking the issue being fixed by this PR

Summary by CodeRabbit

  • New Features

    • Introduced a new method func status() -> NodeStatus in LightningNodeService to fetch node status.
    • Updated the Bitcoin view to display balances and status updates more effectively.
    • Simplified the display of payments in PaymentsListView by organizing them based on status.
  • Refactor

    • Renamed Node type to LdkNode in LightningNodeService.
  • Style

    • Enhanced UI layout, spacing, and styling in BitcoinView and NodeIDView.
  • Chores

    • Removed unused code and functionalities related to error handling and PaymentKind string conversion.
  • Documentation

    • Commented out specific functionalities and error cases for future reference.

reez avatar Apr 08 '24 23:04 reez