blueprint icon indicating copy to clipboard operation
blueprint copied to clipboard

Add current date/time template variables.

Open kurthardin opened this issue 6 years ago • 7 comments

Adds simple support for inserting current date/time components into templates by variable substitution.

kurthardin avatar Nov 07 '19 19:11 kurthardin

Sorry for the delay in taking a look... the concept looks good to me... could you add an integration test for this behavior so we can make sure it stays working.

Let me know if have question on adding a test.

reesemclean avatar Dec 08 '19 21:12 reesemclean

I have some test cleanup changes as well, but I'll save that for a separate pull request unless you'd prefer I include it now.

kurthardin avatar Dec 09 '19 21:12 kurthardin

If it’s unrelated, a separate one is fine... currently the tests are not succeeding on the CI so I need to figure that out as well.

On Dec 9, 2019, at 2:56 PM, Kurt Hardin [email protected] wrote:  I have some test cleanup changes as well, but I'll save that for a separate pull request unless you'd prefer I include it now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

reesemclean avatar Dec 09 '19 21:12 reesemclean

Ok, I'll open a separate request for those changes then since they are unrelated.

BTW, the CI error appears to be related to specifying a fairly old version of rvm in .travis.yml.

kurthardin avatar Dec 09 '19 22:12 kurthardin

Unfortunately that is just the beginning of the issues - the vscode extension test example seems to have changed a bit so working through that. I can manually get this PR through for now though.

On Dec 9, 2019, at 3:16 PM, Kurt Hardin [email protected] wrote:

 Ok, I'll open a separate request for those changes then since they are unrelated.

BTW, the CI error appears to be related to specifying a fairly old version of rvm in .travis.yml.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

reesemclean avatar Dec 09 '19 22:12 reesemclean

Got the extension test running on the CI again, can you resolve the conflicts and then I will merge in and release a new version. Thanks!

reesemclean avatar Dec 10 '19 04:12 reesemclean

1 Message
:book: :tada: Thanks for the Pull Request!

Generated by :no_entry_sign: Danger

BlueprintBot avatar Dec 18 '19 23:12 BlueprintBot