redyetidev
redyetidev
> That in part is why I added the end date. If I remember correctly I very carefully moved that a bit at a time so that we would not...
@nodejs/performance
(Slightly unrelated) Maybe we should add a new `tracker` label to the repo?
That's a good sign (for security) [i think] Do CIs now need approving reviews? 🎉
I make a few changes for performance, and here are my benchmark results: ``` path/basename-posix.js n=100000 pathext='' * -3.78 % ±3.43% ±4.56% ±5.94% path/basename-posix.js n=100000 pathext='/' ** -3.49 % ±2.49%...
While the performance impact seems significant, I don't think it'll be noticeable (but I haven't tested it yet for the actual MS timings). It's just an extra `typeof` check. As...
@anonrig, given the benchmark results, do you think a secondary system w/o URL support should be added for the `toNamespacedPath` function?
> Should we add an error hint where if someone calls a path method with a string URL (not an URL instance) we suggest that they wrap their input in...
> I suspect this will thrown when using permission model I don't think that'll happen, as it's doing all the changes before any path processing really occurs
Also, please lint your source code and commit message. (You just need to the put the change in the commit message, E.G. `test: print failed tests with dot reporter`, and...