vue-plyr icon indicating copy to clipboard operation
vue-plyr copied to clipboard

Running `npm install` requires a git/ssh client

Open set-killer opened this issue 3 years ago • 2 comments

Hello,

In the package.json file there is the dependency section that looks like this:

  "dependencies": {
    "plyr": "github:sampotts/plyr#develop",
    "vue": "^2.6.12"
  },

The problem here is that Plyr is linked directly to the github repository of the Plyr player. So it requires a git client installed on the local machine in order to download this dependency. This is a problem for minimalistic environments (like docker) that does not have git client installed locally.

Running yarn install doesn't require git tho.

Also please do not link the Plyr directly to the develop branch because sometimes develop could be broken with some commits that are not tested vary well. This could be an issue for projects that rely on continuous integration and builds not from cache.

Would it be possible to change the dependency version of Plyr to some stable number like "plyr": "^x.y.z" and to rely on the npmjs provided package? Thank you.

set-killer avatar Dec 08 '20 17:12 set-killer

Same issue here, yarn works fine

muarachmann avatar Mar 06 '21 00:03 muarachmann

Had issues too, used set-killer repo with the version (and not the github reference) of 'plyr' package and it worked.

But now the package does not compile and does not create the dist folder.

How can I fix it?

@redxtech please fix this in the official repo, thanks

diesel701 avatar Mar 30 '21 09:03 diesel701