redwood icon indicating copy to clipboard operation
redwood copied to clipboard

[Bug?]: Published @redwoodjs/forms does not have correct dependencies

Open dphuang2 opened this issue 2 years ago • 1 comments

What's not working?

It seems like @redwoodjs/[email protected] has [email protected] in its package.json but it should be 7.34.2: https://github.com/redwoodjs/redwood/blob/main/packages/forms/package.json

Is there something up with the publishing of @redwoodjs/forms that causes this?

See SS of node_modules source for @redwoodjs/forms Screen Shot 2022-09-09 at 5 09 53 PM

How do we reproduce the bug?

Simply install the latest redwoodjs and observer that yarn.lock has:

"react-hook-form@npm:7.33.1":
  version: 7.33.1
  resolution: "react-hook-form@npm:7.33.1"
  peerDependencies:
    react: ^16.8.0 || ^17 || ^18
  checksum: 6380700d877604be4326c845599240a42bb4eb31109ff47cd6aa9e567a906c9fe512c965396a72c6a0e52a4992922226ea58cf8bfb43d6ebbaa08972e8be4c65
  languageName: node
  linkType: hard

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • [ ] I'm interested in working on this

dphuang2 avatar Sep 10 '22 00:09 dphuang2

@dphuang2 I think you're looking at the main branch. But if you look at this repo at the 2.2.4 tag, you'll see that it's using react-hook-form 7.33.1:

https://github.com/redwoodjs/redwood/blob/62827bd6d5a7eff6d796575fb4b32e780c96dde8/packages/forms/package.json#L28

We always make patches based on the previous patch (and if it's the first patch, based on the minor). So new code is based on old code for patches. Is there a feature you're waiting to be shipped in react hook form?

jtoar avatar Sep 13 '22 15:09 jtoar

@dphuang2 I think you're looking at the main branch. But if you look at this repo at the 2.2.4 tag, you'll see that it's using react-hook-form 7.33.1:

https://github.com/redwoodjs/redwood/blob/62827bd6d5a7eff6d796575fb4b32e780c96dde8/packages/forms/package.json#L28

We always make patches based on the previous patch (and if it's the first patch, based on the minor). So new code is based on old code for patches. Is there a feature you're waiting to be shipped in react hook form?

Got it and makes sense.

And yes—waiting for useFieldArray validation rules for min and max length field arrays.

dphuang2 avatar Sep 24 '22 06:09 dphuang2