redwood
redwood copied to clipboard
bugfix replace slash in tailwind config on windows
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 997e6c5c2c8b018fcf14dc65995e706a8de24237. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 14 targets
-
cli run test --concurrency 2 -- --colors --maxWorkers 2
-
cli run test --concurrency 2 -- --colors --maxWorkers 2
-
cli run test --concurrency 2 -- --colors --maxWorkers 2
-
cli run build
-
cli run build
-
cli run build
-
cli run build
-
cli run test --concurrency 2 -- --colors --maxWorkers 2
-
cli run build
-
cli run build
-
cli run build
-
cli run build
-
cli run build
-
cli run build
Sent with 💌 from NxCloud.
Deploy Preview for redwoodjs-docs ready!
Name | Link |
---|---|
Latest commit | 997e6c5c2c8b018fcf14dc65995e706a8de24237 |
Latest deploy log | https://app.netlify.com/sites/redwoodjs-docs/deploys/62fcf8fd616f1c0008089241 |
Deploy Preview | https://deploy-preview-6203--redwoodjs-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Next steps @pantheredeye:
- rebuild the fixture with
yarn build:test-project --rebuild-fixture --verbose
, and commit the changes into this branch - do a quick manual check on gitpod to see if the UI is looking ok: (use this link: https://gitpod.io/#https://github.com/redwoodjs/redwood/pull/6203)
- rebuild the fixture with
yarn build:test-project --rebuild-fixture --verbose
, and commit the changes into this branch
Except any version changes to RW libraries. Those should stay 3.0-something (It's a little weird right now because we're in a RC phase. This is not the normal workflow)
oh, man. so I have a couple of notes... and it may take me some time to clean this up.
One @dac09 - I ran the rebuild fixture command inside of my redwood framework directory. It took about 20 minutes to complete. Not sure if that was correct. I figured it had to be, so that I could push back to this branch. If not - please let me know.
Then, I committed and tried to push the branch, and it said I was behind and had to pull. I had already sync'd my fork with the main when I first opened up, but I did not think about pulling the branch. So, I pulled after the notice and it went into a merge state... I tried to abandon. 😵💫
I really dove off without a safety net... I found this
git fetch origin
git reset --hard origin
and basically feel like I need to trash my local branch and start over somehow.
Also, @Tobbe - I don't really understand how your last comment affects me:
- rebuild the fixture with
yarn build:test-project --rebuild-fixture --verbose
, and commit the changes into this branchExcept any version changes to RW libraries. Those should stay 3.0-something (It's a little weird right now because we're in a RC phase. This is not the normal workflow)
I thought I would figure it out after running the fixture rebuild. But, I didn't figure it out. I didn't see anything that looked like ~3.0ish.
None of this is pressing. I am probably off for the night. But, any tips would be appreciated. I will look into it when I get time.
It took about 20 minutes to complete. Not sure if that was correct.
Yeah, unfortunately this is not surprising given that you're on Windows. Windows, and the file system that it uses, doesn't handle tasks like that very well 🙁 I timed it on my 2020 Mac M1 and it took 6m41s to run.
it said I was behind and had to pull.
Danny merged the latest changes from the main branch into this PR branch. You can see it in the timeline
If and when you see something like that it means you'll have to pull in the latest changes from your "origin" remote.
I don't really understand how your last comment affects me ... I thought I would figure it out after running the fixture rebuild.
Sorry, I could have been more clear here.
After running yarn build:test-project --rebuild-fixture
you'll see a bunch of files updated. Among those files you'll find three package.json files that have been updated. Looking at one of them on my machine I see this:
diff --git a/__fixtures__/test-project/web/package.json b/__fixtures__/test-project/web/package.json
index 159c08191..3814d0196 100644
--- a/__fixtures__/test-project/web/package.json
+++ b/__fixtures__/test-project/web/package.json
@@ -13,10 +13,10 @@
]
},
"dependencies": {
- "@redwoodjs/auth": "3.0.0-rc.285",
- "@redwoodjs/forms": "3.0.0-rc.285",
- "@redwoodjs/router": "3.0.0-rc.285",
- "@redwoodjs/web": "3.0.0-rc.285",
+ "@redwoodjs/auth": "2.2.3",
+ "@redwoodjs/forms": "2.2.3",
+ "@redwoodjs/router": "2.2.3",
+ "@redwoodjs/web": "2.2.3",
"prop-types": "15.8.1",
"react": "17.0.2",
"react-dom": "17.0.2"
Those are the changes you don't want to commit. So revert back to "3.0.0-rc.285" in all package.json files before running git commit
.
I'm happy to jump on a call and guide you through any/all of this if you want
I want to get a patch out so I'm going to push this one across the finish line. I added Tobbe's suggestion (see https://github.com/redwoodjs/redwood/pull/6203#discussion_r950786342). I rebuilt the fixture but it ended up having no changes except for the migrations (which aren't real changes in this case), so I just added the fixture-ok label instead.