redwood icon indicating copy to clipboard operation
redwood copied to clipboard

[Bug]: CLI output swallows some text (review steps info) in narrow terminal windows

Open Philzen opened this issue 2 years ago • 3 comments

What's not working?

Upgrading an existing project from v1.5.1 to latest (v2.1.1) via yarn rw upgrade, i got:

grafik

Apart from the fact that the word "communit" could clearly make use of an additional "y", i am getting a strong hunch that there is more stuff missing here :wink:


Just to check, i made a 2nd attempt trying to upgrade canary via yarn rw upgrade -t canary and this time i got:

grafik

… so clearly something is going on with the newline / carriage return tricks or whathaveyou in that yarn script. So i resized my terminal window to double the size and got:

grafik

Ah! That's what's supposed to be written there!

Just to be sure, i started a fresh tab, did everything again and again ended up with the result on the 2nd screenshot.

How do we reproduce the bug?

Try running a yarn upgrade command in a narrow terminal window – in my case it happens to be 83 characters wide.

What's your environment? (If it applies)

System:
    OS: Linux 5.15 Manjaro Linux
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.15.1 - /tmp/xfs-052b9714/node
    Yarn: 3.2.0 - /tmp/xfs-052b9714/yarn
  Databases:
    SQLite: 3.39.1 - /usr/bin/sqlite3
  Browsers:
    Firefox: 102.0.1
  npmPackages:
    @redwoodjs/core: ^2.1.1 => 2.1.1

Are you interested in working on this?

  • [X] I'm interested in working on this

Philzen avatar Jul 27 '22 18:07 Philzen

One interesting observation that may point into the direction of what's going on here.

When i run the command in a wide-enough terminal window (as seen on the 2nd image above) everything is fine like this:

grafik

Now, when i resize that window to the half the size (83 chars wide, which is my common setting), it transforms to: grafik

Note the superfluous newlines after each ticked-off step.

Philzen avatar Jul 27 '22 18:07 Philzen

I got the same problem that you, but do you use Gnome Terminal ? I am curious if is not a bug from the terminal itself. I will try on macOS tomorrow,

simoncrypta avatar Jul 28 '22 02:07 simoncrypta

I got the same problem that you, but do you use Gnome Terminal ?

Using xfce4-terminal 1.0.4 over here

Philzen avatar Jul 28 '22 02:07 Philzen