redwood-tutorial icon indicating copy to clipboard operation
redwood-tutorial copied to clipboard

Published 20 hours ago • verified publisher icon redwoodjs

Test ts-to-js

Open rushabhhere opened this issue 2 years ago • 4 comments

Converted the code in https://github.com/redwoodjs/redwood-tutorial/pull/71 to js using rw ts-to-js. The purpose of this PR is to check the diff between the generated js and the code in this repository.

rushabhhere avatar Aug 07 '22 01:08 rushabhhere

Just saw this! Looks like it's the result of our discussion over in #71?

@Tobbe how does this look? I noticed some weirdness likes the @redwoodjs/core version going from 2.2.0 down to 2.0.0? This also doesn't have the new separate form helper file that we're going to generate going forward...

cannikin avatar Sep 29 '22 20:09 cannikin

@cannikin I still believe in the general idea here, but I agree some of the changes look weird. I don't think that's because of ts-to-js though. I think we should bring #71 up to date, and then regenerate this PR to see what the changes look like

Tobbe avatar Oct 02 '22 16:10 Tobbe

@Tobbe @cannikin I have updated this PR with respect to my recent additions to https://github.com/redwoodjs/redwood-tutorial/pull/71, please check.

rushabhhere avatar Oct 16 '22 19:10 rushabhhere

@Tobbe I assume that the merge of decoupled auth is going to affect this PR? In App.js everything is still imported from @redwoodjs/api, and that's just the first thing I checked. There's also changes to .vscode/launch.json which was maybe overridden by @rushabhhere own dev environment?

I don't know that I'm even qualified to approve this: too much TS!

cannikin avatar Nov 07 '22 18:11 cannikin