playground-auth icon indicating copy to clipboard operation
playground-auth copied to clipboard

Ideas to refine AuthResults and PollCurrentVersionCell presentation

Open dthyresson opened this issue 3 years ago • 9 comments

@clairefro asks:

Do we want <AuthResults> or <PollCurrentVersionCell> - they seem to provide similar data

I think we'll want to refine the presentation of both of these components in another issue/pr.

The intent of AuthResults is to show the user info and some basic checks that the content is sensible (ie, it has an email if needed and other attributes.

The intent of PollCurrentVersionCell is to make sure that the token refreshes after it expires -- it the expires at should refresh after say 1 hour in most cases (but depends of provider).

Open to ideas to better present this info more succinctly (but with options to show the raw details).

Let's discuss option here.

dthyresson avatar Apr 20 '21 12:04 dthyresson

Issue https://github.com/redwoodjs/playground-auth/issues/46 is related as is asks if the component should be hidden -- or should null info be replaced with some more meaningful info.

dthyresson avatar Apr 20 '21 12:04 dthyresson

My related thought to this is should the Poll Results also be below the form like the Auth Results? Sometimes when a Provider page is loaded the poll results take a second to load so the form starts at the top and then jumps down. Or we could have loading content in the poll results to prevent the jump.

lunchbreakdev avatar Apr 20 '21 13:04 lunchbreakdev

Open to ideas to better present this info more succinctly (but with options to show the raw details).

Do we think that an optional toggle could work for these? Hidden by default but the user can click a button to view the results. Maybe in a modal? Or do we want it to be more visible just better cleaned up?

lunchbreakdev avatar Apr 20 '21 14:04 lunchbreakdev

I think it can totally be hidden away, it was mostly for us debugging the tokens refreshing!

dac09 avatar Apr 20 '21 17:04 dac09

Do we think something like the below screenshots would work?

A button for each the results and version that opens a modal (HeadlessUI Dialog) with the content.

image

image

lunchbreakdev avatar Apr 20 '21 20:04 lunchbreakdev

Related a bit to: https://github.com/redwoodjs/playground-auth/issues/56

dthyresson avatar Apr 21 '21 13:04 dthyresson

I think it'd be better more cleaned up, instead of a completely separate modal. You should totally use your code formatting block to make it look prettier!

dac09 avatar Apr 21 '21 13:04 dac09

Do we think something like the below screenshots would work?

I like it I think it is worth a deploy preview to see how it feels.

But let's call "Version Data" -> "Refresh Token Status" until I think of a better term.

The intent here is to see that the token has token expired as it polls every few seconds.

Actually, saying something to that effect might be smart and the Poll cell has the interval in seconds set.

The token will refresh itself once real-time reaches the expiresAt (when you got the token + expiresIn usually 1 hr).

dthyresson avatar Apr 21 '21 13:04 dthyresson

@dac09 makes a good point - with the modal hidden, it won't show the status info if there is a problem readily. Unless the button caption informs you of the problem.

dthyresson avatar Apr 21 '21 13:04 dthyresson