demo doesn't work

[mariusa]

https://redwood-example-invoice.netlify.app/#

1. signup
2. click on the link by email
3. app says logged in

"Try it out" doesn't work (does a POST graphql with 500 response) "Get started" says Logged in as test

[thedavidprice]

Hi @mariusa

Ah, indeed it's broken. Sorry about that but thank you for letting us know. It looks like this example project is desperately in need of being updated from ^0.15.4-canary.20 to the most recent Redwood 0.19.2.

No pressure, but might you be interested in helping with the upgrade? If so, it would take looking through the release notes from v0.15 to the latest and making sure the breaking changes are fixed and code modification completed for each Release: https://github.com/redwoodjs/redwood/releases

I know we had a but somewhere along the way where the refresh on Login wasn't working correctly. And it looks like Peter (project owner) might not have "home" set correctly on the LandingPage in his Routes.js.

Oh, lastly, if you're interested in Hacktoberfest, I could add the topic to this repo to opt-in.

Keep me posted either way.

[dale-french]

Hey @thedavidprice - I'd be happy to give this one a shot.

[thedavidprice]

Hi @dale-french That would be awesome! Also, not sure if you’re participating in Hacktoberfest, but I did just opt-in this repo if so.

So there are likely two potential PRs here:

1. upgrade to latest Redwood Version
   • Starting from the Release notes for v0.15.3, work through code mods and breaking changes: https://github.com/redwoodjs/redwood/releases
   • Note: Since v0.15.0 had some changes required, I'd recommend a quick check to make sure it's been updated completely as well.
2. fix the login redirect to /invoices — odds are this will be resolve during the upgrade process. But might not be the case.

Assigning this to you now. Please let me know otherwise.

[dale-french]

@thedavidprice see #41

• I have upgraded Redwood as well as Tailwind as it was causing some issues after upgrade.
• The issue with the login redirect seems to be fixed after the upgrade

I have noticed a couple other issues while working on this:

1. Try it out button on the landing page does not navigate anywhere
2. Once authenticated, Log out button does not redirect back to the landing page
3. There are issues with the DB seed as mentioned in #35
4. Saving an invoice is pretty buggy and only seems to save if fields are physically modified - also after save there is no redirect back to the invoices listing page.

Happy to create issues and a couple PRs to address these if you'd like.

[thedavidprice]

Thanks @dale-french I left some comments and made one small change to .gitignore. Definitely would like to get this merged. FYI: we're going to have some near-term Netlify deploy issues due to this: https://github.com/redwoodjs/redwood/issues/1313

NOTE: in v0.19.3, Redwood upgraded Apollo Client to v3, which has had the effect of breaking implementations in apps, especially when it comes to Cells. Not sure how or if that will affect Example Invoice. But might be the cause of further issues or some of the current issues you've identified.

Additional Issues

Yes, after we get the current PR merged, all the above would be good to start a new Issue conversation with Peter P (who's buried this week, FYI).

1. Try it out I'm not sure what Peter's intent was here --> maybe show the example Invoice (seeded) without needing to Login and without ability to save? Needs more info.
2. Log out bug to be fixed for sure
3. Seed: needs more info from Peter as to original intent (which I believe was to have a "default" state for any new invoice). Might not be applicable. Needs more info.
4. "Saving Invoice": definitely bugs and would be helpful to fix. And might be Apollo Client v3 related.

[thedavidprice]

Some, but not all, issues are resolved with #41

@dale-french leaving this open for discussion about the Issues above. Please close when ready.