redux icon indicating copy to clipboard operation
redux copied to clipboard

Add Expo and React Native examples to CI

Open aryaemami59 opened this issue 1 year ago • 1 comments

This PR:

  • [X] Adds Expo and React Native examples to CI workflow.

aryaemami59 avatar Feb 22 '24 01:02 aryaemami59

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 22 '24 01:02 codesandbox-ci[bot]

Deploy Preview for redux-docs ready!

Name Link
Latest commit 629d600aee90b18571fef1abdf24275fb36ea145
Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/65ed2e0aa0b69b0008ef110e
Deploy Preview https://deploy-preview-4681--redux-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 10 '24 03:03 netlify[bot]

Can we add any caching to this to speed things up? This slows the test suite by nearly 5x and this library isn't React-specific. This seems like overkill to me.

timdorr avatar Mar 10 '24 03:03 timdorr

@timdorr Sure I can figure out some sort of caching to speed this up.

aryaemami59 avatar Mar 10 '24 04:03 aryaemami59

Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together!

timdorr avatar Mar 11 '24 04:03 timdorr

@timdorr

Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together!

That's awesome, thank you Tim! This makes me wonder, would it be okay then to re-open https://github.com/reduxjs/redux-thunk/pull/365?

aryaemami59 avatar Mar 11 '24 07:03 aryaemami59

Unfortunately, I can't reopen that PR (branch is deleted). But feel free to submit a new one and we'll get it merged in.

timdorr avatar Mar 11 '24 17:03 timdorr

@timdorr Thank you!!!

aryaemami59 avatar Mar 11 '24 17:03 aryaemami59

i reopened it 👍🏻

EskiMojo14 avatar Mar 11 '24 17:03 EskiMojo14

@EskiMojo14 Thank you Ben!

aryaemami59 avatar Mar 11 '24 17:03 aryaemami59