redux icon indicating copy to clipboard operation
redux copied to clipboard

[tutorial] Reactions update is broken in <SinglePostPage />

Open dpyzo0o opened this issue 3 years ago • 6 comments

Steps To Reproduce

  1. Click "View Post" for any post
  2. Click the reactions

Link to code example: The codesandbox here

The current behavior

Reactions work for the post list page, not for the single post page.

The expected behavior

  1. Reactions work for single post page
  2. Reactions sync in both list list page and single post page.

dpyzo0o avatar Jun 17 '22 09:06 dpyzo0o

I did an update on apiSlice.js and everything is working fine:

The codesandbox here

dannielss avatar Jun 28 '22 17:06 dannielss

@markerikson How I can update the codesandbox example?

dannielss avatar Jun 28 '22 19:06 dannielss

@dannielss It's... kinda complicated :)

All the sandboxes live in https://github.com/reduxjs/redux-essentials-example-app . Specifically, it's the tutorial-steps branch, with tags applied to specific commits.

To update the sandboxes, you'd actually have to:

  • Clone the repo
  • Check out the tutorial-steps branch
  • Reset the branch all the way to the last commit that added/changed these lines
  • Alter the commit
  • Cherry-pick all commits after that
  • Change all tags to point to the new commits in the branch
  • Force-push it

So, unfortunately not easy, and not something other folks can do atm either

markerikson avatar Jun 28 '22 20:06 markerikson

I started learning redux using docs but unfortunately sandbox examples are broken

MubashirWaheed avatar Jul 21 '22 22:07 MubashirWaheed

@MubashirWaheed : what parts of the sandboxes are broken, specifically?

markerikson avatar Jul 21 '22 23:07 markerikson

Code sandbox for the "basic redux dataflow" under the redux essential is not working on firefox but I just checked and it is working fine chrome

MubashirWaheed avatar Jul 21 '22 23:07 MubashirWaheed