redux icon indicating copy to clipboard operation
redux copied to clipboard

Update devtools extension npm install guide

Open DuBento opened this issue 3 years ago • 8 comments

Thanks for the PR!

To better assist you, please select the type of PR you want to create.

Click the "Preview" tab above, and click on the link for the PR type:

  • :bug: Bug fix or new feature
  • :memo: Documentation Fix
  • :book: New/Updated Documentation Content

DuBento avatar Jan 26 '22 19:01 DuBento

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5fa4c505b1c651e34d4613da59e1c2f8f39a96f3:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

codesandbox-ci[bot] avatar Jan 26 '22 19:01 codesandbox-ci[bot]

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: 5fa4c505b1c651e34d4613da59e1c2f8f39a96f3

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/61f1d8c11ac41400086736a9

😎 Browse the preview: https://deploy-preview-4273--redux-docs.netlify.app

netlify[bot] avatar Jan 26 '22 19:01 netlify[bot]

Actually, I think as of the recent DevTools 3.0 release, it's now a separate scoped package name, per https://github.com/reduxjs/redux-devtools/releases/tag/remotedev-redux-devtools-extension%403.0.0 and https://github.com/reduxjs/redux-devtools/pull/948/files#diff-46ac21909169cd3c3c528d28cca98e1fb32578556269dd06149c3ddb95e95ce2 .

Could you update the PR to match that?

markerikson avatar Jan 26 '22 20:01 markerikson

Note that redux-devtools is now @redux-devtools/core and that redux-devtools-extension is now @redux-devtools/extension. I'm guessing that this should should refer to @redux-devtools/extension, but I'm not certain.

Methuselah96 avatar Jan 26 '22 22:01 Methuselah96

Note that redux-devtools is now @redux-devtools/core and that redux-devtools-extension is now @redux-devtools/extension. I'm guessing that this should should refer to @redux-devtools/extension, but I'm not certain.

I think you are correct. Updated patch.

DuBento avatar Jan 26 '22 23:01 DuBento

@DuBento I believe it's supposed to be @redux-devtools/core now.

timdorr avatar Jan 28 '22 16:01 timdorr

It seems a little out-of-place and outdated to recommend installing @redux-devtools/core without any context on how to use it (and to preface it by saying "Most likely, you'll also need [...] the developer tools."). It seems to me that @redux-devtools/extension should be the recommended way to use the developer tools.

Methuselah96 avatar Jan 28 '22 16:01 Methuselah96

@DuBento I believe it's supposed to be @redux-devtools/core now.

Since I was just looking for extension support, /extension made more sense at the time. But to keep consistent with what was previously in the installation guide maybe I could change to @redux-devtools. Also since someone is mainly looking for the extension support there could be a note suggesting to install only @redux-devtools/extension. Could also use your thoughts on the matter @Methuselah96.

DuBento avatar Jan 29 '22 00:01 DuBento