redux icon indicating copy to clipboard operation
redux copied to clipboard

Update part-6-performance-normalization.md

Open aleksanderantropov opened this issue 4 years ago • 5 comments

To make it consistent with the previous example

Thanks for the PR!

To better assist you, please select the type of PR you want to create.

Click the "Preview" tab above, and click on the link for the PR type:

  • :bug: Bug fix or new feature
  • :memo: Documentation Fix
  • :book: New/Updated Documentation Content

aleksanderantropov avatar Oct 05 '21 20:10 aleksanderantropov

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0407860938fe4fb9b9641a2d2a3c2835b93c36d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

codesandbox-ci[bot] avatar Oct 05 '21 20:10 codesandbox-ci[bot]

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: d0407860938fe4fb9b9641a2d2a3c2835b93c36d

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6165e3e89cd9a0000737c570

😎 Browse the preview: https://deploy-preview-4182--redux-docs.netlify.app

netlify[bot] avatar Oct 05 '21 20:10 netlify[bot]

We actually want to be using the "builder callback" syntax here, not the "object lookup" form. If I missed converting one of the examples to the "builder callback" form, please file a PR to fix that one instead. Thanks!

markerikson avatar Oct 05 '21 20:10 markerikson

Yeah, looks like I did forget to update the notificationsSlice one.

I'll reopen this - can you change the PR to fix that one instead?

markerikson avatar Oct 05 '21 20:10 markerikson

Added another commit with the changes

aleksanderantropov avatar Oct 06 '21 07:10 aleksanderantropov

I apparently updated this elsewhere at some point.

markerikson avatar Aug 19 '22 18:08 markerikson