redux icon indicating copy to clipboard operation
redux copied to clipboard

recommend use of an api cache library in the style guide

Open phryneas opened this issue 3 years ago • 3 comments


name: :book: Recommend use of an api cache library in the style guide about: Add a section to the style guide to use RTK Query or an alternative library.

PR Type

Update an existing page

Checklist

  • [ ] Is there an existing issue for this PR?
  • [ ] Have the files been linted and formatted? No, the linter runs amok on my local machine and tries to format everything differently.

What docs page is being added or updated?

  • Section: Style Guide

For Updating Existing Content

What updates should be made to the page?

Add a section to the style guide to use RTK Query or an alternative library.

Do these updates change any of the assumptions or target audience? If so, how do they change?

They add more emphasis that api cache logic should usually not be written by hand.

@markerikson generally I am very open to pretty much rewording anything in here, but we should probably get RTK-Q mentioned in the style guide.

phryneas avatar Sep 26 '21 08:09 phryneas

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8f0198b4d57a614d9623b01f0b93c1bd9a04e6d:

Sandbox Source
Vanilla Typescript Configuration

codesandbox-ci[bot] avatar Sep 26 '21 08:09 codesandbox-ci[bot]

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: dff59986cb9a39b6aa3f0f4c9628bdeebbfd8cb9

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6150288c04f4890008d2a2e6

😎 Browse the preview: https://deploy-preview-4178--redux-docs.netlify.app

netlify[bot] avatar Sep 26 '21 08:09 netlify[bot]

I'd probably put this one in the later "Recommended" section, alongside "Use Thunks".

markerikson avatar Oct 09 '21 16:10 markerikson

this seems to have been superceded by https://github.com/reduxjs/redux/pull/4460 - (https://redux.js.org/style-guide/#use-rtk-query-for-data-fetching)

okay to close?

EskiMojo14 avatar Feb 12 '24 21:02 EskiMojo14

Yep!

markerikson avatar Feb 12 '24 21:02 markerikson