redux-toolkit icon indicating copy to clipboard operation
redux-toolkit copied to clipboard

fetchBaseQuery: expose extraOptions to prepareHeaders

Open phryneas opened this issue 1 year ago • 6 comments

Triggered by #4290 and the fact that we had similar asks before. Not sure if the extra generic arg is worth it. Thoughts, @EskiMojo14 & @markerikson ?

phryneas avatar Mar 21 '24 22:03 phryneas

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Mar 21 '24 22:03 codesandbox[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 968c2f624bf45bbe835d5a73c729ee58a6e8712b:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

codesandbox-ci[bot] avatar Mar 21 '24 22:03 codesandbox-ci[bot]

Deploy Preview for redux-starter-kit-docs ready!

Name Link
Latest commit 968c2f624bf45bbe835d5a73c729ee58a6e8712b
Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/65fcbdc049d1c400086ba70f
Deploy Preview https://deploy-preview-4291--redux-starter-kit-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 21 '24 22:03 netlify[bot]

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 23.95 KB (+0.06% 🔺)
3. fetchBaseQuery (.modern.mjs) 5.09 KB (+0.25% 🔺)

github-actions[bot] avatar Mar 21 '24 22:03 github-actions[bot]

Would you prefer it like this or without the generic and just unknown? 🤔

phryneas avatar Mar 21 '24 22:03 phryneas

definitely the generic

EskiMojo14 avatar Mar 21 '24 22:03 EskiMojo14