redux-toolkit
redux-toolkit copied to clipboard
reduxjs
Update oazapfts to 6.0.2
Some issues (s. #3814) have been fixed in upstream library oazapfts so this is an attempt to update it to the latest version.
The major updates that this update has stepped over are mainly regarding changes to exported files that have been addressed by this PR.
oazapfts now includes comments in the generated types, so I also needed to update the snapshot tests.
closes #3814
![codesandbox[bot] avatar](https://avatars.githubusercontent.com/in/206332?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for redux-starter-kit-docs ready!
| Name | Link |
|---|---|
| Latest commit | 7939056789f7668f82669d705dfce574d2abd67d |
| Latest deploy log | https://app.netlify.com/sites/redux-starter-kit-docs/deploys/660e97add64165000888e8df |
| Deploy Preview | https://deploy-preview-4198--redux-starter-kit-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 7939056789f7668f82669d705dfce574d2abd67d:
| Sandbox | Source |
|---|---|
| rsk-github-issues-example | Configuration |
| @examples-query-react/basic | Configuration |
| @examples-query-react/advanced | Configuration |
| @examples-action-listener/counter | Configuration |
| rtk-esm-cra | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
Any update to this? Definitely would love to have the updates to oazapfts :)
I am trying to keep this PR up to date with master to keep it reviewable, but I haven't heard back.
@markerikson, you have responded in the corresponding issue a while ago. Any chance you could look into this PR any time soon? I'd be glad to rework anything that prevents this PR from being merged.
I'm currently working on a project that could use this update! I'm happy to contribute if needed.
By the way, oazapfts already updated the package to address negative enum values on version 6.0.6 which solves issue #4455. The latest version is 6.0.10, so many fixes could be included. Let me know if you guys need some help.
@yamilelias , @SimonEggert : yeah, apologize for the complete delay and falling through the cracks on this one. There's been a couple factors. Lenz did all the initial work on the codegen, but hasn't had much time for Redux maintenance over the last year. I've been busy with personal life and all my Redux-related time this year has gone to trying to update our tutorial (and frankly also tried to filter out all codegen related discussion because I haven't worked on it and I don't have the brain space to think about it).
Skimming this, it seems reasonable at first glance.
I'll go ahead and merge this and then figure out how to get this published!
Drat. Tried to publish it and ran into some kind of an NPM-related issue.
I don't have time to investigate this now, but I will try to look at it as soon as i have time. (Realistically that may not be until Sunday or early next week.)
@markerikson code-gen was deployed 9 months ago, so probably it's still on your todo list? :)
Should be live in https://github.com/reduxjs/redux-toolkit/releases/tag/%40rtk-query%2Fcodegen-openapi%402.0.0-alpha.0 ! Please try it out and let us know if it works.
Works like a charm. On my end, types are greatly improved. Schema definitions like:
{ "YourApi": { "properties": { "someParam": { "type": ["null", "string"] } } } }
are now correctly typed as:
type YourApiArg = { someParam: null | string }
instead of any.
Thank you 🙏🏾
