redux-toolkit icon indicating copy to clipboard operation
redux-toolkit copied to clipboard

Fix wrong extension on docs

Open fmcalado opened this issue 2 years ago • 2 comments

TypeScript examples had .js extension

fmcalado avatar Oct 02 '22 19:10 fmcalado

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b9818ab6a75d81c07d7761e3aff28ac787af0f4:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

codesandbox-ci[bot] avatar Oct 02 '22 19:10 codesandbox-ci[bot]

Deploy Preview for redux-starter-kit-docs ready!

Name Link
Latest commit 6b9818ab6a75d81c07d7761e3aff28ac787af0f4
Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6339ea7bb90e6f000892dcc3
Deploy Preview https://deploy-preview-2741--redux-starter-kit-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 02 '22 19:10 netlify[bot]

I understand the intent, but this arguably adds more inconsistency rather than reducing it.

image

The snippet titles are the same for both TS & JS tabs, so one of them is always going to be wrong. @phryneas might be able to comment on how feasible it would be to have a different version for each.

Unless we manage to get all extensions consistent, based on whether the TS or JS tab is selected, then we ought to keep them one way or the other.

I'm slightly inclined to say that when showing files as '.js' to a TS user, they are more likely to understand by themselves that a 'js' extension merely needs to be replaced with 'ts' for their version, whereas showing '.ts' to a plain JS user would instead have them attempt to create the file with a 'ts' extension, and get stuck.

Shrugsy avatar Jan 24 '23 11:01 Shrugsy