redux-devtools icon indicating copy to clipboard operation
redux-devtools copied to clipboard

devtools-cli does not respect hostname and port settings

Open MichaelMarner opened this issue 4 years ago • 3 comments

It appears as though devtools-cli does not use hostname and port settings specified on the command line. This is causing problems when trying to migrate from the old remotedev to devtools-cli, as it is not possible to connect to a local server without manually changing the settings after devtools is open.

Steps to reproduce

  1. Run devtools-cli with hostname and port settings specified as documented:
redux-devtools --hostname=localhost --port=8000 --open

Expected behaviour

Devtools will be running and connected to the local server.

Actual behaviour

Devtools will not be connected to anything. Looking at the settings tab will show remotedev.io preselected.

The local connection needs to be selected each time devtools server is running.

Related issues

https://github.com/MichaelMarner/dart-redux-remote-devtools/issues/29

https://github.com/MichaelMarner/dart-redux-remote-devtools/pull/30

MichaelMarner avatar Aug 20 '20 01:08 MichaelMarner

Thanks for the issue, although as noted here, I see this more as a feature request than a bug. Regardless, I'll look into making it so that the Electron app automatically connects if the hostname and port are specified on the command line.

Methuselah96 avatar Aug 20 '20 03:08 Methuselah96

Hey @Methuselah96, thanks for the further info. Really I just want to make sure I get the documentation right for users of my project.

Just to clarify, doing the following:

redux-devtools --hostname=localhost --port=8000

and opening http://localhost:8000, also does not connect to the locally running server. You still need to go to settings and switch from remotedev.io to local server. This is not the behaviour or the old remotedev, which would automatically connect to the local server when opened in a browser.

So I think this is either a bug/regression, or the documentation needs to be updated because the behaviour is unclear to me.

I know you intend to retire remotedev.io, so I'm assuming this won't be an issue for much longer anyway.

Thanks!

MichaelMarner avatar Aug 20 '20 05:08 MichaelMarner

Have a related issue but with the --open flag. When opening in the browser or electron the protocol and hostname are not respected.

For example:

  • redux-devtools --protocol=https --host=app.local --open - Electron will open to a white screen.
  • redux-devtools --protocol=https --host=app.local --open=browser - Will open a browser window to http://localhost:8000 I am able to manually navigate to https://app.local:8000 and can view it in the browser.

Here is an attempt to resolve the --open flag part of this: https://github.com/reduxjs/redux-devtools/pull/1217

smacpherson64 avatar Aug 24 '22 20:08 smacpherson64