redux-devtools icon indicating copy to clipboard operation
redux-devtools copied to clipboard

[Fix] react-json-tree: Handle sparse empty arrays greater than limit

Open arcataroger opened this issue 10 months ago • 1 comments

Potentially fixes #1827

Given an input like:

let sparseArrayBroken = [];
sparseArrayBroken[50] = "this will cause a crash";
<JSONTree data={sparseArrayBroken}/>

Currently getCollectionEntries() and its isRange() call does not properly handle sparse arrays greater than the limit. It will try to pass through empty entries to the isRange() and subsequent const { key, value } = entry destructuring, both of which halt the script.

This PR bypasses the crash and allows the rendering to continue.

There is a separate cosmetic bug that this PR does NOT fix:

  • If limitedEntries in getCollectionEntries() is not subset, but limit - 4 === length - 5, it will cause a single-item collapsed range
  • And if the item(s) in that single-item range are empty, expanding that range will just cause it to disappear: Screenshot 001019
  • Probably it doesn't need to be range-ified at all in that case, but that's outside the scope of this PR

arcataroger avatar Feb 07 '25 20:02 arcataroger

⚠️ No Changeset found

Latest commit: 8084678c91e750725fcc16c1518c41a8baed548d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 07 '25 20:02 changeset-bot[bot]