xabber-android icon indicating copy to clipboard operation
xabber-android copied to clipboard

Client lags when scrollback history is long

Open konomikitten opened this issue 6 years ago • 12 comments

I was trying to figure out what was causing significant lag on Xabber Beta and after messing around a bit I discovered a long history buffer significant slows down the client when you send a message (Probably from the window updating). Occurs on 453 but didn't occur on 405. I believe the bug is probably related to the new UI design as the person who uses this client never clears their history and after I cleared the history the performance issue went away.

Possible solutions would be adding a setting for how much history can be remember or only loading a page of recent history etc.

Please note I originally reported this on the Play Store but have since deleted the review because the Play Store is awful for bug reporting.

Model: OPPO R7sf ColorOS: v2.1.0i Android: 5.1.1 Xabber: Beta 2.2(453)

konomikitten avatar Dec 30 '17 07:12 konomikitten

I think I have the same issue on Xabber 2.2(454). The client is almost unusably slow (laggy input, and 1-2 second delay when sending a message) in a conversation with a long history.

jannisteunissen avatar Jan 09 '18 19:01 jannisteunissen

We're looking into this. Sees like it's somehow related to predictive Google keyboard.

andrewnenakhov avatar Jan 09 '18 19:01 andrewnenakhov

@KonomiKitten @jannisteunissen we did some performance improvements in latest Xabber Beta 2.3 (471). Please, check it put and tell us.

Str4tocaster avatar Mar 26 '18 11:03 Str4tocaster

@Str4tocaster I would check but I am currently using the Xabber VIP version and don't have the beta installed at the moment, if someone else could test that would be great if not I'll reinstall the beta.

konomikitten avatar Mar 26 '18 11:03 konomikitten

Is there a way to import my chat history into the beta client? Because the problems seemed to show up with a long history

jannisteunissen avatar Mar 26 '18 11:03 jannisteunissen

@jannisteunissen if your server supports message archive, just scroll up until you run out of history, or get tired, whichever happens first. But we checked it with history of a several thousand entries, sent in a span of a couple of years

andrewnenakhov avatar Mar 26 '18 12:03 andrewnenakhov

@andrewnenakhov My server unfortunately doesn't support message archive, but great that the performance of the client has been improved!

jannisteunissen avatar Mar 26 '18 12:03 jannisteunissen

Has Xabber VIP got this change yet? If so I can test this strait away. Please confirm.

konomikitten avatar Apr 19 '18 06:04 konomikitten

@KonomiKitten Yes, Xabber VIP from Google Play got this changes.

Str4tocaster avatar Apr 19 '18 06:04 Str4tocaster

@Str4tocaster well on my mobile now and I'm not seeing any awful lag sending messages and I have a quite sizable scrollback, so I feel this is pretty much fixed.

konomikitten avatar Apr 19 '18 07:04 konomikitten

I think I jumped the gun on this and I only scrolled the window and forgot to check that when a message is sent it lags. I'm reopening this. The current bug is: Once the scrollback buffer gets long enough sending a new message is slow (aka when it gets pushed onto the screen it takes a long time). I'm convinced the only way to fix this properly is to have the scrolback buffer limited to a certain amount of lines and have it push old messages off the buffer as new ones come in. An infinite scrollback buffer like the current implementation has will always eventually get slow with enough messages, it needs to be changed.

konomikitten avatar Apr 29 '18 03:04 konomikitten

@KonomiKitten Thanks for your investigation we will think about it.

Str4tocaster avatar May 03 '18 05:05 Str4tocaster