HeroicBashLauncher icon indicating copy to clipboard operation
HeroicBashLauncher copied to clipboard

[Feature Request] Run from terminal without user input

Open eskay993 opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Assuming it can't be done already, would you consider adding a command line option to run HBL silently, or without the zenity popups or any user input?

Use case: I'm incorporating HBL into a script that I have that does all sorts of things I need. The script automatically triggers when it detects changes in a specific directory and runs HBL (among other things). Having HBL pop up a dialogue box interrupts the script and requires user input.

EDIT: I just noticed the popup disappears after a few seconds, which is good from a script flow perspective for my use case, but still takes focus away from whatever the user is doing when running in the background.

Describe the solution you'd like Something like HeroicBashLauncher --silent

What do you think? Thanks for your consideration.

Love HBL! Really solved some issues I was having launching Heroic games. Thanks for your efforts.

eskay993 avatar Sep 19 '22 10:09 eskay993

There was PR created exactly for this purpose but it never moved forward. I was thinking about adding a command-line option myself.

I'll implement this whenever I find the time.

redromnon avatar Sep 19 '22 11:09 redromnon

Awesome! Thanks for the quick response.

eskay993 avatar Sep 19 '22 13:09 eskay993

The only other obstacle is that desktop users need to manually select the games they want to add to Steam. This is currently handled by a simple Zenity GUI list. Does your script makes use of this too?

redromnon avatar Sep 21 '22 16:09 redromnon

For me personally, in my case I don't use the AddToSteam feature. My script just runs HBL to generate the _Heroic.sh files which I then use for other stuff. For testing, I created a version with all the zenity calls in HeroicBashLauncher.py commented out, and it works great with my script for my needs.

I would imagine though, in a case where someone wants to automate HBL without user interaction, they would either want all games added to Steam or no games added to Steam. So maybe this ties back into the other feature request with autoaddtosteam? Not sure if that is more complicated to do on desktop.

eskay993 avatar Sep 21 '22 17:09 eskay993

I would imagine though, in a case where someone wants to automate HBL without user interaction, they would either want all games added to Steam or no games added to Steam. So maybe this ties back into the other feature request with autoaddtosteam? Not sure if that is more complicated to do on desktop.

Yeah, I'm currently thinking about it. But it's not very complicated to implement.

redromnon avatar Sep 22 '22 07:09 redromnon

So I've implemented the --silent parameter that skips GUI dialogs. Feel free to test the build - https://github.com/redromnon/HeroicBashLauncher/actions/runs/3127458252

redromnon avatar Sep 26 '22 11:09 redromnon

Sorry for the delay.

Thanks for this. Working great! My script is very happy :)

Out of interest, did you change anything with AddToSteam on desktop? I haven't tested this but if you have, I'll give that a test as well.

eskay993 avatar Sep 30 '22 09:09 eskay993

Well, I haven't changed anything for desktop users. But for Deck users, I have created a setting that allows Deck users to not make HBL add the scripts directly to Steam but create the AddToSteam.sh script instead. Just like desktop users.

redromnon avatar Sep 30 '22 12:09 redromnon

Feature included in v3.0.0

redromnon avatar Oct 07 '22 16:10 redromnon