react-native-check-app-install icon indicating copy to clipboard operation
react-native-check-app-install copied to clipboard

React Native 0.60 support

Open scarlac opened this issue 5 years ago • 7 comments

This warning is presented when running the packager with react-native start:

warn The following packages use deprecated "rnpm" config that will stop working from next release:
  - react-native-check-app-install: https://github.com/redpandatronicsuk/react-native-check-app-install#readme

The fix might be as simple as this one from maps: https://github.com/react-native-community/react-native-maps/pull/2975/files

scarlac avatar Sep 23 '19 21:09 scarlac

Looks like @redpandatronicsuk has a PR open for this. https://github.com/redpandatronicsuk/react-native-check-app-install/pull/17 What needs to be done to get this merged in?

clickclickonsal avatar Oct 25 '19 13:10 clickclickonsal

@clickclickonsal I don’t think it solves this issue. see the linked Pr.

scarlac avatar Oct 25 '19 14:10 scarlac

Tested on android 8 release build.

https://github.com/johnnytest470/react-native-check-app-install/commit/f8948e696a1a90deece931d1fd8d1c2d26e3151a

johnnytest470 avatar Jan 02 '20 11:01 johnnytest470

Tested on android 8 release build.

johnnytest470@f8948e6

Why has this not been merged in yet?

Thelin90 avatar Feb 24 '20 21:02 Thelin90

Hi there, when will #17 be merged in? thanks

a-vorontsov avatar Apr 08 '20 17:04 a-vorontsov

Hi there, when will #17 be merged in? thanks

Would be interesting for our team as well. Is a new release planned for the next days?

afiller avatar May 28 '20 13:05 afiller

I've tried the suggested patch and added it with patch-package. It doesn't work. Error-Message still remain. And for me it's absolutely logical, because the solution is to remove rnpm from the package.json of the Component ... like the ThreadOpener notice.

So here the Steps: create the react-native.config.js File in node_modules/react-native-check-app-install/ and put this inside:

module.exports = {
  project: {
    ios: {},
    android: {
      sourceDir: './android',
    },
  },
};

Then Remove the following lines from package.json:

    "rnpm": {
        "android": {
            "sourceDir": "./android"
        }
    },

That's it. I've created an PR for it

xstable avatar Jun 19 '20 09:06 xstable