redpanda
redpanda copied to clipboard
redpanda-data
cluster: add test for mixing maintenance and decommissioning
Following c1bcf59c057f417288889d344579c29e9c3fef36, we no longer use the removed state, and we no longer keep removed nodes in the members_table::_nodes container. This means that the check preventing multiple nodes in maintenance mode now correctly ignores removed nodes, allowing us to intermix maintenance mode and decommissioning.
This commit adds a test for this, and adjusts some comments to reflect the existing behavior.
Backports Required
- [x] none - not a bug fix
- [ ] none - issue does not exist in previous branches
- [ ] none - papercut/not impactful enough to backport
- [ ] v22.3.x
- [ ] v22.2.x
- [ ] v22.1.x
UX Changes
Release Notes
@andrwng does it make sense to test the inverse case? That putting a node into maintenance mode while it is being decommissioned doesn't cause an issue? (CC @mattschumpert )
@andrwng does it make sense to test the inverse case? That putting a node into maintenance mode while it is being decommissioned doesn't cause an issue? (CC @mattschumpert )
Done
Noticed this one hanging around when writing up a related issue. Just pushed a rebase
is this ready for another review (unrequested reviews)
Yes, please do give this a look!
@andrwng is this PR still valid ?
I don't think so. Node membership code has been changed pretty significantly since this PR. The test might still be worth having, but reviving this isn't on my near-term TODO list.