redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard
verified publisher icon redpanda-data

rpk: encourage users to restart nodes on config change if required

Open daisukebe opened this issue 3 years ago • 1 comments

Fixes https://github.com/redpanda-data/redpanda/issues/7420

Backports Required

  • [ ] none - not a bug fix
  • [ ] none - issue does not exist in previous branches
  • [ ] none - papercut/not impactful enough to backport
  • [x] v22.3.x
  • [x] v22.2.x
  • [ ] v22.1.x

UX Changes

Upon completion of rpk cluster config edit or rpk cluster config set, print the following message if restart is required:

Cluster needs to be restarted. See more details with 'rpk cluster config status'

daisukebe avatar Nov 22 '22 07:11 daisukebe

@daisukebe - can we packport this change to 22.2.x too

emaxerrno avatar Nov 22 '22 17:11 emaxerrno

/backport v22.2.8

daisukebe avatar Nov 23 '22 02:11 daisukebe

/backport v22.3.4

daisukebe avatar Nov 23 '22 02:11 daisukebe

The pull request is not merged yet. Cancelling backport...

Workflow run logs.

vbotbuildovich avatar Nov 23 '22 02:11 vbotbuildovich

The pull request is not merged yet. Cancelling backport...

Workflow run logs.

vbotbuildovich avatar Nov 23 '22 02:11 vbotbuildovich

Fixed the failed test.

daisukebe avatar Nov 24 '22 09:11 daisukebe

Thanks ! @daisukebe

r-vasquez avatar Nov 25 '22 12:11 r-vasquez

/backport v22.2.x

daisukebe avatar Nov 25 '22 13:11 daisukebe

/backport v22.3.x

daisukebe avatar Nov 25 '22 13:11 daisukebe

@daisukebe fyi i update the release notes section of the pr body

andrewhsu avatar Dec 06 '22 14:12 andrewhsu