redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard

admin: read-after-write consistency for config status on leader node

Open jcsp opened this issue 3 years ago • 2 comments
trafficstars

Cover letter

admin: read-after-write consistency for config status on leader node

Previously, after writing a config update, API clients could do
a /status query to the same node and not see any nodes (including
the leader that they just PUT to) reflect the new version.

With this change, if the client is talking to the controller leader,
it will reliably see the new config version reflected in the /status
result when querying the same node again after a PUT.

This is a little subtle and later we should make simpler rules
for this via a higher level "wait for status updates" as part
of the PUT call itself: https://github.com/redpanda-data/redpanda/issues/5833

Related: https://github.com/redpanda-data/redpanda/pull/5609

Backport Required

  • [ ] not a bug fix
  • [ ] papercut/not impactful enough to backport
  • [ ] v22.2.x
  • [X] v22.1.x
  • [ ] v21.11.x

UX changes

None

Release notes

  • none

jcsp avatar Aug 04 '22 10:08 jcsp

This had a couple failures in ClusterConfigTest, will need to take a look at whether those tests have incorrect assumptions or if something else is up.

jcsp avatar Aug 05 '22 17:08 jcsp

CI failures:

  • https://github.com/redpanda-data/redpanda/issues/5276
  • https://github.com/redpanda-data/redpanda/issues/5020

jcsp avatar Aug 09 '22 12:08 jcsp

restarted ci since the pr is a bit old, but otherwise looks good

dotnwat avatar Aug 16 '22 04:08 dotnwat

CI failures are:

  • https://github.com/redpanda-data/redpanda/issues/5276
  • test_cancelling_partition_move_x_core (there are three issues, I didn't check which one it was!)

jcsp avatar Aug 16 '22 08:08 jcsp

/backport v22.2.x

jcsp avatar Aug 16 '22 08:08 jcsp

/backport v22.1.x

jcsp avatar Aug 16 '22 08:08 jcsp