redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard

Poor error message when old node joins cluster

Open travisdowns opened this issue 3 years ago • 0 comments

Version & Environment

Redpanda version: d334e7cedef828b5580b5dfe7d5e0e2557bcfa72

What went wrong?

If an old node joins a cluster, it fails to join, which is good. What is not good is that the reason for the failure is obscured in the log which shows this as the error cause:

redpanda::main - application.cc:255 - Failure during startup: seastar::abort_requested_exception (abort requested)

What should have happened instead?

The error cause should indicate the true failure reason, that an old node joined instead. This will help both us and end users quickly diagnose the failure reason.

How to reproduce the issue?

  1. Run rptest.tests.cluster_features_test.FeaturesNodeJoinTest.test_old_node_join and examine the redpanda log

You can see an example of the error message in https://github.com/redpanda-data/redpanda/pull/5059.

Additional information

When this is changed, the BadLogLines allow list needs to updated as well since the fix for #5059 uses the existing "abort requested" error message.

travisdowns avatar Aug 03 '22 17:08 travisdowns