redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard

[CORE-13742] dt: Add cloud topics to 'partition_move_interruption_test.py'.

Open oleiman opened this issue 1 month ago • 9 comments

Basically what it says on the tin. Rather than expanding the param matrices on these tests, this PR uses recently introduced KgoVerifierMulti* producers & consumers to add a second topic (w/ CT enabled) to each of them.

In most cases, we'll do more work in the test body to account for the second topic, but it's generally thought preferable to limit combinatorial explosion of parametrized test cases since it puts pressure on available node parallelism.

Example run: https://buildkite.com/redpanda/redpanda/builds/77167#019add14-0d1f-4ee4-9e3a-037369dc5138

Backports Required

  • [x] none - not a bug fix
  • [ ] none - this is a backport
  • [ ] none - issue does not exist in previous branches
  • [ ] none - papercut/not impactful enough to backport
  • [ ] v25.3.x
  • [ ] v25.2.x
  • [ ] v25.1.x
  • [ ] v24.3.x

Release Notes

  • none

oleiman avatar Dec 02 '25 00:12 oleiman

/ci-repeat 1 release tests/rptest/tests/partition_move_interruption_test.py

oleiman avatar Dec 02 '25 00:12 oleiman

/ci-repeat 1 release skip-redpanda-build skip-units skip-rebase tests/rptest/tests/partition_move_interruption_test.py

oleiman avatar Dec 02 '25 03:12 oleiman

CI Failure:

oleiman avatar Dec 02 '25 04:12 oleiman

Retry command for Build#77167

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancellations_interrupted_with_restarts@{"cloud_storage_type":1,"replication_factor":1}

vbotbuildovich avatar Dec 02 '25 04:12 vbotbuildovich

CI test results

test results on build#77167
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
PartitionMoveInterruption test_cancellations_interrupted_with_restarts {"cloud_storage_type": 1, "replication_factor": 1} integration https://buildkite.com/redpanda/redpanda/builds/77167#019add14-0d1f-4ee4-9e3a-037369dc5138 FLAKY 8/21 The test was found to be new, and no failures are allowed https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionMoveInterruption&test_method=test_cancellations_interrupted_with_restarts
test results on build#77230
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ShadowLinkingMetricsTests test_link_metrics null integration https://buildkite.com/redpanda/redpanda/builds/77230#019ae2be-1ad4-4ef9-8727-eac94affcd59 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingMetricsTests&test_method=test_link_metrics
PartitionMoveInterruption test_cancellations_interrupted_with_restarts {"cloud_storage_type": 1, "replication_factor": 3} integration https://buildkite.com/redpanda/redpanda/builds/77230#019ae2b5-85a0-4901-8a00-36fb54781bb9 FLAKY 6/21 The test was found to be new, and no failures are allowed https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionMoveInterruption&test_method=test_cancellations_interrupted_with_restarts
PartitionMoveInterruption test_cancelling_partition_move {"cloud_storage_type": 1, "compacted": true, "force_back": false, "replication_factor": 3, "unclean_abort": true} integration https://buildkite.com/redpanda/redpanda/builds/77230#019ae2be-1ad8-4be2-a995-be165166bb4d FLAKY 20/21 The test was found to be new, and no failures are allowed https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionMoveInterruption&test_method=test_cancelling_partition_move

vbotbuildovich avatar Dec 02 '25 04:12 vbotbuildovich

Retry command for Build#77215

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancellations_interrupted_with_restarts@{"cloud_storage_type":1,"replication_factor":1}
tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancellations_interrupted_with_restarts@{"cloud_storage_type":1,"replication_factor":3}

vbotbuildovich avatar Dec 02 '25 23:12 vbotbuildovich

dope

dotnwat avatar Dec 03 '25 03:12 dotnwat

tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancellations_interrupted_with_restarts@{"cloud_storage_type":1,"replication_factor":1} tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancellations_interrupted_with_restarts@{"cloud_storage_type":1,"replication_factor":3}

Unfortunately this test may be actually broken. @Lazin is looking into it I think.

oleiman avatar Dec 03 '25 04:12 oleiman

Retry command for Build#77230

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancelling_partition_move@{"cloud_storage_type":1,"compacted":true,"force_back":false,"replication_factor":3,"unclean_abort":true}
tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancellations_interrupted_with_restarts@{"cloud_storage_type":1,"replication_factor":3}

vbotbuildovich avatar Dec 03 '25 07:12 vbotbuildovich