redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard

admin/server: make admin_server::redirect_to_leader a non-coroutine

Open bashtanov opened this issue 7 months ago • 6 comments

There seems to be no reason for it to be a coroutine, it does not co_await anything and did not 4 years ago when it was created.

Backports Required

  • [ ] none - not a bug fix
  • [ ] none - this is a backport
  • [ ] none - issue does not exist in previous branches
  • [x] none - papercut/not impactful enough to backport
  • [ ] v25.1.x
  • [ ] v24.3.x
  • [ ] v24.2.x

Release Notes

  • none

bashtanov avatar May 21 '25 13:05 bashtanov

/dt

bashtanov avatar May 21 '25 13:05 bashtanov

/dt

bashtanov avatar May 21 '25 22:05 bashtanov

/dt

bashtanov avatar Jun 04 '25 08:06 bashtanov

/dt

bashtanov avatar Jun 10 '25 07:06 bashtanov

CI test results

test results on build#67084
test_class test_method test_arguments test_kind job_url test_status passed reason
MasterTestSuite consumer_group unit https://buildkite.com/redpanda/redpanda/builds/67084#019758b8-d083-49a9-971c-8ef6f15f698f FAIL 0/1
PartitionMovementUpgradeTest test_basic_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/67084#019758f7-6627-4c1d-9b95-1ee44fa0cf21 FLAKY 19/21 upstream reliability is '99.27272727272727'. current run reliability is '90.47619047619048'. drift is 8.79654 and the allowed drift is set to 50. The test should PASS
PartitionReassignmentsTest test_add_partitions_with_inprogress_reassignments ducktape https://buildkite.com/redpanda/redpanda/builds/67084#019758f7-6628-48fd-bd95-38e308d97c1f FLAKY 19/21 upstream reliability is '95.10086455331412'. current run reliability is '90.47619047619048'. drift is 4.62467 and the allowed drift is set to 50. The test should PASS
DisablingPartitionsTest test_disable ducktape https://buildkite.com/redpanda/redpanda/builds/67084#019758f7-6627-4a49-8bba-e53c41e2438a FLAKY 19/21 upstream reliability is '91.78947368421052'. current run reliability is '90.47619047619048'. drift is 1.31328 and the allowed drift is set to 50. The test should PASS

vbotbuildovich avatar Jun 10 '25 10:06 vbotbuildovich

/ci-repeat 1

bashtanov avatar Jun 11 '25 16:06 bashtanov