CORE-2161: cloud_storage/topic_manifest: force negative retention to mean infinite retention

[andijcr]

this mirrors what's done for retention_bytes. the reasoning is that if somebody performs a manual edit of the topic manifest and writes "retention_duration" : -1, it's probably done to mirror the retention.ms semantic of meaning infinite retention

this a followup on https://github.com/redpanda-data/redpanda/pull/14355#discussion_r1428255190

Backports Required

• [ ] none - not a bug fix
• [ ] none - this is a backport
• [ ] none - issue does not exist in previous branches
• [ ] none - papercut/not impactful enough to backport
• [x] v24.1.x
• [x] v23.3.x

Release Notes

Improvements

• allow interpreting 'retention_duration' = -1 in a topic_manifest.json file as infinite time retention

[vbotbuildovich]

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46992#018e8a4c-9707-45e6-87f9-b7cfb07db1bd

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46992#018e8cce-f70c-47cc-894f-88c7a3b6df64

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47708#018f1209-7c76-409e-8f1b-8ae486b99abb

[andijcr]

/ci-repeat 1

[dotnwat]

/ci-repeat 1

[dotnwat]

@andijcr can you take a look at the ci failures?

[andijcr]

/ci-repeat 1

[andijcr]

failure was only in the recently-fixed https://redpandadata.atlassian.net/browse/CORE-2629 https://github.com/redpanda-data/redpanda/pull/18055

re-running ci since the previous run is quite old

[dotnwat]

what's the status of this @andijcr? its approved, but it looks like something changed? (the re-request review buttons are active).

[andijcr]

what's the status of this @andijcr? its approved, but it looks like something changed? (the re-request review buttons are active).

I updated the cover letter to update the backport list; maybe that?

[vbotbuildovich]

/backport v24.1.x

[vbotbuildovich]

/backport v23.3.x